[Data Fusion] Partial Aggregation Changes #20008
Open
+147
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables partial mode for average aggregations.
Basically introduces a physical plan optimizer which checks for average aggregation and enables it as Partial mode.
The goal is to achieve something similar with distinct count case, where we can retrieve hll sketch as an byte array in a follow-up.
Note: This might fail with current sql as sql is sending avg as sum & count in a single query. Although should not fail as it will still use sum/count individual aggregation execs in data fusion. For my local testing, I am sending avg as itself and not sending 2 different sum & count requests as we are doing it from sql presently.
How am I achieving it:
For aggregation exec:
For projection exec:
Testing:
Check out the query testing & physical plans as they were executed (printed from logs):
avg:
min:
max:
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.