[WIP] OCPBUGS-63472: Include --copy-network for all ABI installations #8155

rwsu · 2025-10-25T02:00:09Z

The --copy-network flag needs to be included so that network configuration changes applied through the agent-tui/nmtui persist after the node reboots.

List all the issues related to this PR

What environments does this code impact?

Automation (CI, tools, etc)
Cloud
Operator Managed Deployments
None

How was this code tested?

assisted-test-infra environment
dev-scripts environment
Reviewer's test appreciated
Waiting for CI to do a full test run
Manual (Elaborate on how it was tested)
No tests needed

Checklist

Title and description added to both, commit and PR.
Relevant issues have been associated (see CONTRIBUTING guide)
This change does not require a documentation update (docstring, docs, README, etc)
Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

Are the title and description (in both PR and commit) meaningful and clear?
Is there a bug required (and linked) for this change?
Should this PR be backported?

The --copy-network flag needs to be included so that network configuration changes applied through the agent-tui/nmtui persist after the node reboots.

openshift-ci-robot · 2025-10-25T02:00:15Z

openshift-ci · 2025-10-25T02:00:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rwsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~cmd/agentbasedinstaller/OWNERS~~ [rwsu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rwsu · 2025-10-25T02:03:02Z

/jira refresh

openshift-ci-robot · 2025-10-25T02:03:10Z

@rwsu: This pull request references Jira Issue OCPBUGS-63472, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

codecov · 2025-10-25T03:46:05Z

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.15%. Comparing base (f026180) to head (6a194ad).

Files with missing lines	Patch %	Lines
cmd/agentbasedinstaller/register.go	0.00%	19 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8155      +/-   ##
==========================================
- Coverage   43.16%   43.15%   -0.01%     
==========================================
  Files         404      404              
  Lines       69872    69880       +8     
==========================================
- Hits        30161    30159       -2     
- Misses      37008    37017       +9     
- Partials     2703     2704       +1

Files with missing lines	Coverage Δ
cmd/agentbasedinstaller/register.go	`9.72% <0.00%> (-0.38%)`	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

openshift-ci · 2025-10-25T07:28:30Z

@rwsu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/edge-e2e-ai-operator-ztp	`6a194ad`	link	true	`/test edge-e2e-ai-operator-ztp`
ci/prow/edge-lint	`6a194ad`	link	true	`/test edge-lint`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

andfasano · 2025-10-27T07:51:46Z

cmd/agentbasedinstaller/register.go

+	// In ABI, the --copy-network flag should always be included in the installer args.
+	// The flag is added if the infraenv is found to have static networking configured.
+	// See https://github.com/openshift/assisted-service/blob/f026180842bb99cc97d5597fd1bfaa483a55828b/internal/host/hostcommands/install_cmd.go#L368
+	// Here we add a dummy static network config to force the --copy-network flag


Based on our previous discussion, I think that a slightly safer implementation could be the check the presence of any keyfile in the live environment to conditionally decide to set the infraEnvParams.InfraenvCreateParams.StaticNetworkConfig: that should cover both the case when the user defines some static network configuration via install-config/agent-config file, either when it's just added via agent TUI (ignoring instead when it's not set all).

andfasano · 2025-10-27T07:54:48Z

cmd/agentbasedinstaller/register.go

+	// Here we add a dummy static network config to force the --copy-network flag
+	// to be added. The dummy network config is not applied to the hosts.
+	netYaml := `interfaces:
+- ipv4:


I like the idea of a dummy network config, but I'd expect something simpler or more "dummy", ie something like:

- routes:

Right now it's just evaluated later by AS (and in case of ABI never applied), but anyhow I'd prefer to have a really simple definition

andfasano · 2025-10-27T07:56:13Z

cmd/agentbasedinstaller/register.go

+			},
+		},
+	}
+	infraEnvParams.InfraenvCreateParams.StaticNetworkConfig = dummyStaticNetworkConfig


In general this solution may work from 4.21+, where we have in plan to enable the infraenv late binding. But I don't think it will work for 4.20, where currently the registerIfnraEnv step is ignored

OCPBUGS-63472: Include --copy-network for all ABI installations

6a194ad

The --copy-network flag needs to be included so that network configuration changes applied through the agent-tui/nmtui persist after the node reboots.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2025

openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 25, 2025

openshift-ci bot requested review from andfasano and zaneb October 25, 2025 02:00

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 25, 2025

openshift-ci bot requested a review from mhanss October 25, 2025 02:03

andfasano reviewed Oct 27, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WIP] OCPBUGS-63472: Include --copy-network for all ABI installations #8155

[WIP] OCPBUGS-63472: Include --copy-network for all ABI installations #8155

Uh oh!

rwsu commented Oct 25, 2025

Uh oh!

openshift-ci-robot commented Oct 25, 2025

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

Uh oh!

openshift-ci bot commented Oct 25, 2025

Uh oh!

rwsu commented Oct 25, 2025

Uh oh!

openshift-ci-robot commented Oct 25, 2025

Uh oh!

codecov bot commented Oct 25, 2025 •

edited

Loading

Uh oh!

openshift-ci bot commented Oct 25, 2025

Uh oh!

andfasano Oct 27, 2025

Uh oh!

andfasano Oct 27, 2025

Uh oh!

andfasano Oct 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[WIP] OCPBUGS-63472: Include --copy-network for all ABI installations #8155

Are you sure you want to change the base?

[WIP] OCPBUGS-63472: Include --copy-network for all ABI installations #8155

Uh oh!

Conversation

rwsu commented Oct 25, 2025

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

Uh oh!

openshift-ci-robot commented Oct 25, 2025

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

Uh oh!

openshift-ci bot commented Oct 25, 2025

Uh oh!

rwsu commented Oct 25, 2025

Uh oh!

openshift-ci-robot commented Oct 25, 2025

Uh oh!

codecov bot commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

openshift-ci bot commented Oct 25, 2025

Uh oh!

andfasano Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

andfasano Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

andfasano Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Oct 25, 2025 •

edited

Loading