[USHIFT-6106] - Add RHEL 10.0 support to bootc containerfiles, image blueprints, and repo config #5689
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
approved
|
/retest |
|
/test verify |
kasturinarra
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@agullon could you please help review ? thanks !! |
There was a problem hiding this comment.
We are installing RHEL 9 RPMs. As such, we need to have only RHEL 9 fast-datapath repo.
There was a problem hiding this comment.
@ggiguash when you say we are installing RHEL 9 RPMs you mean the microshift rpms are based on RHEL9 ?
There was a problem hiding this comment.
Yes, ART do not intend to build RHEL 10 RPMs until we switch to RHEL 10 only.
| COPY ./rpm-repos/$USHIFT_RPM_REPO_NAME $USHIFT_RPM_REPO_PATH | ||
|
|
||
| # Copy repository configuration | ||
| COPY ./bootc-images/$USHIFT_RPM_REPO_NAME.repo ./bootc-images/microshift-fast-datapath-rhel10.repo ./bootc-images/microshift-rhocp-y.repo \ |
There was a problem hiding this comment.
We are installing RHEL 9 RPMs. As such, we need to have only RHEL 9 fast-datapath repo.
See the existing test/image-blueprints-bootc/layer2-presubmit/group1/rhel100-bootc-source.containerfile
There was a problem hiding this comment.
We do not support ostree builds on RHEL 10.
This file should be deleted
There was a problem hiding this comment.
We do not support ostree builds on RHEL 10.
This file should be deleted
There was a problem hiding this comment.
thanks, i noted this information somewhere but i could not find it.. so added it.. Will remove it.
There was a problem hiding this comment.
Any specific reason we do not want to do this ? I remember you talked about this in the microshift engineering meeting but cannot recall.
There was a problem hiding this comment.
ostree-composer still exists on RHEL 10, but it can only generate images of up-to-9-version of RHEL.
We're already testing RHEL 9 images.
kasturinarra
force-pushed
the
USHIFT-6106-containerfiles
branch
2 times, most recently
from
6d355d6 to
8f8a36e
Compare
|
/test images |
kasturinarra
force-pushed
the
USHIFT-6106-containerfiles
branch
from
8f8a36e to
9c12e15
Compare
…repo config - Add 7 bootc containerfiles for RHEL 10.0 (brew, brew-ec, brew-rc, brew-zstream, crel variants) - Only includes current version (4.21) support, no Y-1/Y-2 support as RHEL 10 is new - Comment out serialsim build code for now
kasturinarra
force-pushed
the
USHIFT-6106-containerfiles
branch
from
9c12e15 to
acbb4cb
Compare
|
/test test-unit |
| COPY ./rpm-repos/$USHIFT_RPM_REPO_NAME $USHIFT_RPM_REPO_PATH | ||
|
|
||
| # Copy repository configuration | ||
| COPY ./bootc-images/$USHIFT_RPM_REPO_NAME.repo ./bootc-images/microshift-fast-datapath-rhel9.repo ./bootc-images/microshift-rhocp-y.repo \ |
There was a problem hiding this comment.
should we update this microshift-fast-datapath-rhel9.repo to rhel10 or it does not exist yet?
There was a problem hiding this comment.
It does exist, intially that is what i have created but here is the recommendation from giga, so changed it back to rhel9.repo #5689 (comment)
There was a problem hiding this comment.
ok, we should make a note to ourselves to not forge this in the future
| #COPY --chmod=755 ./bootc-images/build-serialsim.sh /tmp/build-serialsim.sh | ||
| #RUN /tmp/build-serialsim.sh && rm -f /tmp/build-serialsim.sh |
There was a problem hiding this comment.
why these 2 lines are commented? should they be removed?
There was a problem hiding this comment.
@agullon i see building serialsim is failing on RHEL10, so commented it out. More info in the thread here: https://redhat-internal.slack.com/archives/C03CJTNLKAT/p1762336549365219?thread_ts=1762329457.739089&cid=C03CJTNLKAT
There was a problem hiding this comment.
ok, we should make a note to ourselves to not forge this in the future
|
@kasturinarra why you only added them for bootc and not rpm-ostree? |
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agullon, kasturinarra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by ci |
openshift-ci-robot
added
the
verified
|
@kasturinarra: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@kasturinarra: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
Which issue(s) this PR addresses: Add RHEL 10.0 support to bootc containerfiles, image blueprints, and repo config
Closes #