Skip to content

Conversation

@stuggi
Copy link
Contributor

@stuggi stuggi commented Nov 17, 2025

This commit upgrades the ovn-operator to use Operator SDK version 1.41.1, with the following major changes:

Project Structure:

  • Move pkg/ packages to internal/ following Go best practices
  • Move controllers/ to internal/controller/ per new operator-sdk layout
  • Replace main.go with cmd/main.go
  • Add controller and webhook test suites

Configuration Updates:

  • Split certificate management into separate metrics and webhook certs
  • Add network policies for metrics and webhook traffic
  • Rename auth_proxy resources to metrics for clarity
  • Add admin RBAC roles for all CRD types
  • Update manager deployment configuration and patches
  • Modernize kustomization configurations

Webhook Changes:

  • Add dedicated webhook implementation in internal/webhook/v1beta1/
  • Remove old CRD webhook and CA injection patches
  • Update webhook manifests and service configuration

Cleanup:

  • Remove obsolete config patches and overlays

Dependencies:

  • Update go.mod and go.sum for operator-sdk 1.41.1 dependencies

Jira: OSPRH-21981

Assisted-by: claude-4-sonnet

Depends-On: openstack-k8s-operators/openstack-operator#1683
Depends-On: openstack-k8s-operators/install_yamls#1110

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/11ad47434ee942ab8fe625361cc9b4d5

openstack-k8s-operators-content-provider FAILURE in 10m 17s
⚠️ ovn-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@stuggi stuggi force-pushed the operator_sdk_1.41.1 branch from 272e05f to 2bdaa4d Compare November 17, 2025 08:48
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/21f422975c754ab393612c63241734e4

openstack-k8s-operators-content-provider FAILURE in 9m 53s
⚠️ ovn-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@stuggi stuggi force-pushed the operator_sdk_1.41.1 branch 2 times, most recently from 2b0980b to 7ecf3be Compare November 17, 2025 09:43
@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/openstack-operator for 1683,19db487cf23204e39d5f67be71ad37d8a1632c92

@stuggi
Copy link
Contributor Author

stuggi commented Nov 17, 2025

recheck

@stuggi
Copy link
Contributor Author

stuggi commented Nov 17, 2025

/retest

1 similar comment
@stuggi
Copy link
Contributor Author

stuggi commented Nov 17, 2025

/retest

@stuggi stuggi force-pushed the operator_sdk_1.41.1 branch 3 times, most recently from 93f260e to bd5dc53 Compare November 20, 2025 10:43
@stuggi
Copy link
Contributor Author

stuggi commented Nov 20, 2025

/retest

@stuggi stuggi force-pushed the operator_sdk_1.41.1 branch from bd5dc53 to b4ce9d5 Compare November 21, 2025 12:59
This commit upgrades the ovn-operator to use Operator SDK version 1.41.1,
with the following major changes:

Project Structure:
- Move pkg/ packages to internal/ following Go best practices
- Move controllers/ to internal/controller/ per new operator-sdk layout
- Replace main.go with cmd/main.go
- Add controller and webhook test suites

Configuration Updates:
- Split certificate management into separate metrics and webhook certs
- Add network policies for metrics and webhook traffic
- Rename auth_proxy resources to metrics for clarity
- Add admin RBAC roles for all CRD types
- Update manager deployment configuration and patches
- Modernize kustomization configurations

Webhook Changes:
- Add dedicated webhook implementation in internal/webhook/v1beta1/
- Remove old CRD webhook and CA injection patches
- Update webhook manifests and service configuration

Cleanup:
- Remove obsolete config patches and overlays

Dependencies:
- Update go.mod and go.sum for operator-sdk 1.41.1 dependencies

Jira: OSPRH-21981

Assisted-by: claude-4-sonnet
Signed-off-by: Martin Schuppert <[email protected]>
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e33eaf2 into openstack-k8s-operators:main Nov 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants