Skip to content

Conversation

@stuggi
Copy link
Contributor

@stuggi stuggi commented Nov 17, 2025

This commit upgrades the telemetry-operator to use Operator SDK version 1.41.1, with the following major changes:

Project Structure:

  • Move pkg/ packages to internal/ following Go best practices
  • Move controllers/ to internal/controller/ per new operator-sdk layout
  • Replace main.go with cmd/main.go
  • Add controller and webhook test suites

Configuration Updates:

  • Split certificate management into separate metrics and webhook certs
  • Add network policies for metrics and webhook traffic
  • Rename auth_proxy resources to metrics for clarity
  • Add admin RBAC roles for all CRD types
  • Update manager deployment configuration and patches
  • Modernize kustomization configurations

Webhook Changes:

  • Add dedicated webhook implementation in internal/webhook/v1beta1/
  • Remove old CRD webhook and CA injection patches
  • Update webhook manifests and service configuration

Cleanup:

  • Remove obsolete config patches and overlays

Dependencies:

  • Update go.mod and go.sum for operator-sdk 1.41.1 dependencies

Jira: OSPRH-22020

Assisted-by: claude-4-sonnet

Depends-On: openstack-k8s-operators/openstack-operator#1683
Depends-On: openstack-k8s-operators/install_yamls#1110

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/83fbd28a68f7456b8f3b5f2b6e1674f6

openstack-k8s-operators-content-provider FAILURE in 12m 16s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ cifmw-pod-zuul-files SUCCESS in 4m 45s
telemetry-openstack-meta-content-provider-master FAILURE in 8m 48s
⚠️ telemetry-operator-multinode-default-telemetry SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ functional-tests-osp18 SKIPPED Skipped due to failed job telemetry-openstack-meta-content-provider-master
⚠️ functional-periodic-telemetry-with-ceph SKIPPED Skipped due to failed job telemetry-openstack-meta-content-provider-master

@stuggi stuggi force-pushed the operator_sdk_1.41.1 branch from 25b6115 to d22a3f0 Compare November 17, 2025 15:13
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8267cfd4cd7946ea8a9ec9f214875365

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 50m 03s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 48s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 38s
telemetry-openstack-meta-content-provider-master FAILURE in 8m 24s
✔️ telemetry-operator-multinode-default-telemetry SUCCESS in 1h 28m 48s
⚠️ functional-tests-osp18 SKIPPED Skipped due to failed job telemetry-openstack-meta-content-provider-master
⚠️ functional-periodic-telemetry-with-ceph SKIPPED Skipped due to failed job telemetry-openstack-meta-content-provider-master

@stuggi
Copy link
Contributor Author

stuggi commented Nov 18, 2025

/retest

@stuggi
Copy link
Contributor Author

stuggi commented Nov 18, 2025

recheck

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f42a8d561f184f7a8d3cb4c7025202f4

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 51m 49s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 12s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 41s
telemetry-openstack-meta-content-provider-master FAILURE in 8m 20s
✔️ telemetry-operator-multinode-default-telemetry SUCCESS in 1h 32m 35s
⚠️ functional-tests-osp18 SKIPPED Skipped due to failed job telemetry-openstack-meta-content-provider-master
⚠️ functional-periodic-telemetry-with-ceph SKIPPED Skipped due to failed job telemetry-openstack-meta-content-provider-master

@stuggi
Copy link
Contributor Author

stuggi commented Nov 19, 2025

/retest

@stuggi
Copy link
Contributor Author

stuggi commented Nov 19, 2025

those multiple Depends-On to one and another to the same project don't work. removing these for now:

Depends-On: #789
Depends-On: openstack-k8s-operators/openstack-operator#1697

@stuggi
Copy link
Contributor Author

stuggi commented Nov 19, 2025

/retest

@stuggi
Copy link
Contributor Author

stuggi commented Nov 19, 2025

recheck

@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/telemetry-operator for 788,d22a3f058fc3fe44c028d0353b418c0ee9214f3d

@softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/openstack-operator#1683 is needed.

@stuggi stuggi force-pushed the operator_sdk_1.41.1 branch from aa282c8 to b511207 Compare November 21, 2025 12:55
This commit upgrades the telemetry-operator to use Operator SDK version 1.41.1,
with the following major changes:

Project Structure:
- Move pkg/ packages to internal/ following Go best practices
- Move controllers/ to internal/controller/ per new operator-sdk layout
- Replace main.go with cmd/main.go
- Add controller and webhook test suites

Configuration Updates:
- Split certificate management into separate metrics and webhook certs
- Add network policies for metrics and webhook traffic
- Rename auth_proxy resources to metrics for clarity
- Add admin RBAC roles for all CRD types
- Update manager deployment configuration and patches
- Modernize kustomization configurations

Webhook Changes:
- Add dedicated webhook implementation in internal/webhook/v1beta1/
- Remove old CRD webhook and CA injection patches
- Update webhook manifests and service configuration

Cleanup:
- Remove obsolete config patches and overlays

Dependencies:
- Update go.mod and go.sum for operator-sdk 1.41.1 dependencies

Jira: OSPRH-22020

Assisted-by: claude-4-sonnet
Signed-off-by: Martin Schuppert <[email protected]>
@stuggi stuggi force-pushed the operator_sdk_1.41.1 branch from b511207 to 0311e52 Compare November 21, 2025 13:05
@stuggi
Copy link
Contributor Author

stuggi commented Nov 24, 2025

/retest

telemetry-operator is special in the kuttl config compared to others.
it defined test dirs in kuttl-test.yaml and uses an sed in install_yamls
to change it if needed.
Other operators pass an updated test path to the kubectl-kutt command in
install_yamls.

Because of that we
* keep the old tests path in kuttl-test.yaml.
* use a link tests -> test dir

When a fix landed in install_yamls to be the same as other operators,
we remove the link and update the kuttl-test.yaml.

Signed-off-by: Martin Schuppert <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temporary workaround which will be removed in a later follow-up

Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bf35154 into openstack-k8s-operators:main Nov 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants