add getProxies in precompile #2207
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
open-junius
added
the
skip-cargo-audit
open-junius
requested review from
JohnReedV,
ales-otf,
camfairchild,
grbIzl,
gztensor,
l0r1s,
sam0x17 and
shamil-gadelshin
camfairchild
requested changes
Nov 14, 2025
This reverts commit 77a8082.
common/src/lib.rs
Outdated
| Self::SudoUncheckedSetCode => Ok(14), | ||
| Self::SwapHotkey => Ok(15), | ||
| Self::SubnetLeaseBeneficiary => Ok(16), | ||
| Self::RootClaim => Err(()), |
Collaborator
There was a problem hiding this comment.
Is this intentional? I thought we added root claim operations to proxy filter.
Contributor
Author
There was a problem hiding this comment.
Yes. The RootClaim in the ProxyType. But it is excluded in the impl TryFrom for ProxyType. So I think it is not convertible for this type. That is why I explicitly implement TryInto.
l0r1s
reviewed
Nov 25, 2025
l0r1s
reviewed
Nov 25, 2025
l0r1s
reviewed
Nov 25, 2025
sam0x17
approved these changes
Dec 2, 2025
l0r1s
approved these changes
Dec 2, 2025
ales-otf
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add getProxies function in precompile.
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.