Skip to content

Remove SORTPP_PASS which breaks modern Windows SDKs. #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kelson42 merged 1 commit into from
Nov 25, 2025
Merged

Remove SORTPP_PASS which breaks modern Windows SDKs. #1017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ public_conf.set('LIBZIM_WITH_XAPIAN', xapian_dep.found())

if build_machine.system() == 'windows'
win_deps = declare_dependency(
compile_args: ['-DSORTPP_PASS'],
link_args: ['-lRpcrt4', '-lWs2_32', '-lwinmm', '-lshlwapi']
Copy link

@dg0yt dg0yt Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link_args: ['-lRpcrt4', '-lWs2_32', '-lwinmm', '-lshlwapi']
link_args: ['-lrpcrt4', '-lws2_32', '-lwinmm', '-lshlwapi']

for mingw on case-sensitive non-windows systems.

Copy link
Collaborator

@veloman-yunkan veloman-yunkan Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dg0yt Let the PR serve the purpose formulated in its title/description. But feel free to submit a different PR with this change.

)
else
Expand Down
Loading