[#68715] Fix incorrect (British) usage: "expiry" vs "expiration" #20870
+109
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myabc
force-pushed
the
bug/68679-session-ttl-not-toggleable
branch
3 times, most recently
from
5b88778 to
6955290
Compare
myabc
force-pushed
the
bug/68679-replace-expiry-with-expiration
branch
from
48f0cfb to
3a1d4bb
Compare
myabc
force-pushed
the
bug/68679-replace-expiry-with-expiration
branch
from
3a1d4bb to
33a510b
Compare
myabc
changed the title
myabc
force-pushed
the
bug/68679-replace-expiry-with-expiration
branch
from
d390168 to
f897fef
Compare
myabc
commented
Nov 7, 2025
| OPENPROJECT_AUTOLOGIN__COOKIE__PATH (default="/") Cookie path for autologin cookie | ||
| OPENPROJECT_AVAILABLE__LANGUAGES (default=["ca", "cs", "de", "el", "en", "es", "fr", "hu", "id", "it", "ja", "ko", "lt", "nl", "no", "pl", "pt-BR", "pt-PT", "ro", "ru", "sk", "sl", "sv", "tr", "uk", "vi", "zh-CN", "zh-TW"]) Available languages | ||
| OPENPROJECT_AVATAR__LINK__EXPIRY__SECONDS (default=86400) Cache duration for avatar image API responses | ||
| OPENPROJECT_AVATAR__LINK__EXPIRATION__SECONDS (default=86400) Cache duration for avatar image API responses |
Contributor
Author
There was a problem hiding this comment.
@oliverguenther Not sure of the best way to handle renaming environment variables in deployments?
|
Caution The provided work package version does not match the core version Details:
Please make sure that:
|
MayaBerd
reviewed
Nov 10, 2025
| # OpenProject is an open source project management software. | ||
| # Copyright (C) the OpenProject GmbH | ||
| # | ||
| # This program is free software; you can redistribute it and/or |
Contributor
There was a problem hiding this comment.
Suggested change
| # This program is free software; you can redistribute it and/or | |
| # This program is a free software; you can redistribute it and/or |
MayaBerd
reviewed
Nov 10, 2025
| # Copyright (C) 2006-2013 Jean-Philippe Lang | ||
| # Copyright (C) 2010-2013 the ChiliProject Team | ||
| # | ||
| # This program is free software; you can redistribute it and/or |
Contributor
There was a problem hiding this comment.
Suggested change
| # This program is free software; you can redistribute it and/or | |
| # This program is a free software; you can redistribute it and/or |
Contributor
There was a problem hiding this comment.
This paragraph sounds partially repetitive of the one above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/68715
What are you trying to accomplish?
Renames "expiry" to "expiration" in:
avatar_link_expirytoavatar_link_expiration_seconds)What approach did you choose and why?
Merge checklist