[#68481] Remove new project overview feature flag #20897
+99
−451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HDinger
requested changes
Nov 4, 2025
Contributor
There was a problem hiding this comment.
I think this test is still usefull, it just has to be changed to the dashboard page instead of overview, doesn't it?
Contributor
Author
There was a problem hiding this comment.
@HDinger this spec was just a copy of modules/overviews/spec/features/managing_dashboard_page_spec.rb but with the feature flag disabled.
| expect(page).to have_heading "Project home" | ||
| end | ||
|
|
||
| it "can navigate to other modules (regression #55024)" do |
Contributor
There was a problem hiding this comment.
Same here.. I think we should keep the test, but starting from the Dashboard page.
Contributor
|
I think it is safer to keep the feature flag alive for 17.0 but force it to true with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/68481
What are you trying to accomplish?
Removes
new_project_overviewfeature flag and all accompanying code branches.Merge checklist