Implementation/68723 redesign document show page for collaborative document with blocknote

[akabiru]

Ticket

https://community.openproject.org/wp/68723

What are you trying to accomplish?

Implement redesigned layout for real-time collaborative documents

Screenshots

Mobile

What approach did you choose and why?

There are several workarounds to get the desired layout- D-Team approved.

Merge checklist

• Added/updated tests
• Added/updated documentation in Lookbook (patterns, previews, etc)
• Tested major browsers (Chrome, Firefox, Edge, ...)

[brunopagno]

I've tested out locally. The UI is looking neat, and the flow is quite nice. I don't think I see any blockers in merging this one.

But I wonder if there's any risk to allow accessing the /edit page when the document is marked as collaborative (if the user manually types the URL to that page). Because if the document is saved on the CKEditor form then the data could become out of sync.

Problems for us to solve as we continue implementing things

[brunopagno]

I'm afraid of global changes. How can I know that this is not going to have collateral effects somewhere else?

[HDinger]

Thanks for noticing and not just ignoring this @brunopagno 🙇
The change is actually from me 😅 The mixin is only used in one other place, so the impact is rather small. Due to the new way of handling PageHeaders on mobile, this is actually important and a bug we fixed 👍

[brunopagno]

👏

[brunopagno]

Seeing this again, I believe we will need to cleanup a bunch the parameters for the block_note_editor. This could easily be a model: model and let the editor figure out which parameters it needs. Also it is way too structured to work for only documents.

But nothing to be done here. Just thinking aloud.

[akabiru]

But I wonder if there's any risk to allow accessing the /edit page when the document is marked as collaborative (if the user manually types the URL to that page). Because if the document is saved on the CKEditor form then the data could become out of sync.

Nice catch! As we don't have the title edit flow yet, we should be okay to handle this in the upcoming inline title edit work. Also, since blocknote & ckeditor persist on different columns- should be ok in the interim?

[brunopagno]

Nice catch! As we don't have the title edit flow yet, we should be okay to handle this in the upcoming inline title edit work. Also, since blocknote & ckeditor persist on different columns- should be ok in the interim?

That's not the case anymore. BlockNote (or, more specifically Hocuspocus) saves both binary and markdown. But I'm not worried while we're in dev cycle. But I believe we shouldn't release like this.

[akabiru]

As we don't have the title edit flow yet,

That's not the case anymore. BlockNote (or, more specifically Hocuspocus) saves both binary and markdown. But I'm not worried while we're in dev cycle. But I believe we shouldn't release like this.

Agree, definitely we shouldn't (and wouldn't) release this way. I'll include this in the next PR! 👍🏾 WP: https://community.openproject.org/wp/69051