[#68705] When project is copied, work packages with empty mandatory custom fields are not copied

[dombesz]

Ticket

https://community.openproject.org/work_packages/68705

What are you trying to accomplish?

Bypass work package custom field validation when copying projects.

What approach did you choose and why?

Disable model validation in the WorkPackage::CopyProjectContract.

Merge checklist

• Added/updated tests
• Added/updated documentation in Lookbook (patterns, previews, etc)
• Tested major browsers (Chrome, Firefox, Edge, ...)

[toy]

I think it would be better to change the copy project succeeds with errors to fail for some other reason (for example create(:work_package, :skip_validations, subject: "", …) to keep the error test and localised error test, and add a separate test that doesn't fail for required custom field.

[toy]

Should there be a check that work package copying failed?

[dombesz]

The work package copying should succeed even if the work package is invalid.

[toy]

The work package, not project

[dombesz]

The work package also.

[toy]

I understood that when copying a project and one of the work packages fails to be copied, it does copy the project, doesn't copy problematic work packages and reports errors

[dombesz]

That is true only in certain cases, ie. if the validation fails on the work package contract, then the error is reported and the problematic work package is not copied.
However the validations on the work package model itself are skipped (due to the def validate_model? = false). Since the custom fields are validated on the model level, they are skipped too, thus the work package copying will succeed.