Use coefficient_ring in serialization
#5420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5420 +/- ##
==========================================
- Coverage 84.18% 83.99% -0.19%
==========================================
Files 717 721 +4
Lines 98241 98479 +238
==========================================
+ Hits 82701 82715 +14
- Misses 15540 15764 +224
🚀 New features to boost your workflow:
|
fingolfin
approved these changes
Oct 6, 2025
Member
fingolfin
left a comment
fingolfin
left a comment
There was a problem hiding this comment.
Looks good to me and should not break anything.
fingolfin
added
serialization
release notes: not needed
antonydellavecchia
approved these changes
Oct 7, 2025
Collaborator
antonydellavecchia
left a comment
antonydellavecchia
left a comment
There was a problem hiding this comment.
Much cleaner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned here this change is necessary to make Oscar compatible with Nemocas/AbstractAlgebra.jl#2182.