node:worker_threads: improve error messages, support environmentData, emit worker event#18768

Merged

Jarred-Sumner merged 101 commits intomainfrom

ben/worker-threads-2

May 9, 2025

Commits on Apr 4, 2025

Emit online event before Worker entrypoint runs
Ben Grant
committed
Accept callback in MessagePort.close
Ben Grant
committed

Commits on Apr 7, 2025

Merge branch 'main' into ben/worker-threads-2
Ben Grant
committed

Commits on Apr 8, 2025

Pass test-worker-type-check.js
Ben Grant
committed
Use more appropriate #include for errors
Ben Grant
committed
Correct receiveMessageOnPort error message
Ben Grant
committed
Add passing test
Ben Grant
committed
Use defaultGlobalObject
Ben Grant
committed
Merge branch 'main' into ben/worker-threads-2
Ben Grant
committed
Fire worker event on process
Ben Grant
committed

Commits on Apr 9, 2025

Support worker environment data
Ben Grant
committed
Add test-worker-abort-on-uncaught-exception-terminate.js
Ben Grant
committed
Refine error message for duplicates in transferList
Ben Grant
committed
`bun run clang-format`

190n
authored and
github-actions[bot]
committed

Commits on Apr 10, 2025

Do not unref worker on main thread when terminated
Ben Grant
committed
Terminate the VM in Worker.requestTerminate()
Ben Grant
committed
Add missing files
Ben Grant
committed
Handle termination exception in next tick queue
Ben Grant
committed
Use exit code 1 if Worker entry point fails to load
Ben Grant
committed
Allow termination exception while fetching builtin
Ben Grant
committed

Commits on Apr 11, 2025

Clean up exception handling in BunProcess.cpp
Ben Grant
committed
Add more exception checks to JSNextTickQueue
Ben Grant
committed
Merge branch 'main' into ben/worker-threads-2
Ben Grant
committed
Fix crash on workerData with no options
Ben Grant
committed
Fix null environment data
Ben Grant
committed
Do not propagate termination exception to event loop
Ben Grant
committed
Un-todo "worker terminating forcefully properly interrupts" and fix expected exit code
Ben Grant
committed
Resolve Worker entrypoint on worker thread instead of main
Ben Grant
committed
new tests
Ben Grant
committed
Delete TODO
Ben Grant
committed

Commits on Apr 12, 2025

Rename Worker.requestTerminate -> notifyNeedTermination to align with JSC
Ben Grant
committed
Fix not firing messages sent before Worker started
Ben Grant
committed
Fix expectations in worker_threads test to align with Node
Ben Grant
committed
Add comment
Ben Grant
committed
Use code 0 for workers terminated before they start running
Ben Grant
committed

Commits on Apr 14, 2025

Use right exit code for workers terminated at different times
Ben Grant
committed
Update test for behavior changes
Ben Grant
committed
Do not terminate worker in isMainThread test
Ben Grant
committed

Commits on Apr 15, 2025

WIP StatWatcher fixes
Ben Grant
committed
Fix overriding process.exit code
Ben Grant
committed
Revert "Accept callback in MessagePort.close"
Ben Grant
committed
Remove failing test
Ben Grant
committed
Use threadId -1 for exited Workers
Ben Grant
committed
Fix test-worker-http2-generic-streams-terminate.js
Ben Grant
committed

Commits on Apr 16, 2025

Merge branch 'main' into ben/worker-threads-2
Ben Grant
committed
Do not call UDP socket error handler on termination exception
Ben Grant
committed
Add exception checks in evaluateCommonJSModuleOnce
Ben Grant
committed
cleanup
Ben Grant
committed

Commits on Apr 18, 2025

Merge branch 'main' into ben/worker-threads-2
Ben Grant
committed
Do not call uv_library_shutdown
Ben Grant
committed
Add exception checks to createNodeURLBinding
Ben Grant
committed
Run skipped test
Ben Grant
committed
Add some exception checks
Ben Grant
committed

Commits on Apr 21, 2025

Add exception checks
Ben Grant
committed
Merge branch 'main' into ben/worker-threads-2
Ben Grant
committed
Forbid termination exception in test-timeout-behavior
Ben Grant
committed
Do not expose termination exception when test times out
Ben Grant
committed
empty commit to see if zig fmt action is fixed
Ben Grant
committed

Commits on Apr 23, 2025

Merge branch 'main' into ben/worker-threads-2
Ben Grant
committed

Commits on Apr 30, 2025

clean up worker_thread_check.ts
Ben Grant
committed
Merge branch 'main' into ben/worker-threads-2
Ben Grant
committed
Merge branch 'main' into ben/worker-threads-2
Ben Grant
committed
Undo faster termination change and remove associated tests
Ben Grant
committed
don't wait 10 seconds
Ben Grant
committed
delete test-worker-voluntarily-exit-followed-by-throw
Ben Grant
committed
delete test-worker-process-exit-async-module
Ben Grant
committed
delete test-worker-abort-on-uncaught-exception-terminate
Ben Grant
committed

Commits on May 2, 2025

skip broken test
Ben Grant
committed
add ScriptExecutionContextIdentifier binding
Ben Grant
committed
replace translate-c symbol instead of ptrCasting
Ben Grant
committed
error checking
Ben Grant
committed
Merge branch 'main' into ben/worker-threads-2
Ben Grant
committed
finish merge
Ben Grant
committed
try unref
Ben Grant
committed
no conflicts
Ben Grant
committed

Commits on May 3, 2025

remove broken tests
Ben Grant
committed
clean up fireEarlyMessages
Ben Grant
committed
try this
Ben Grant
committed

Commits on May 5, 2025

Add comment
Ben Grant
committed
Remove nodeWorkerObjectSymbol
Ben Grant
committed
Merge branch 'main' into ben/worker-threads-2
Ben Grant
committed
Address review feedback
Ben Grant
committed
Remove unnecessary exception check
Ben Grant
committed
Check URLs are valid
Ben Grant
committed

Commits on May 6, 2025

Merge branch 'main' into ben/worker-threads-2
Jarred-Sumner
authored
Use JSBoundFunction instead of BoundEmitFunction
Ben Grant
committed
Undo bindings changes
Ben Grant
committed
Add some exception checks
Ben Grant
committed

Commits on May 7, 2025

Delete unnecessary overload
Ben Grant
committed
Use helper methods for errors
Ben Grant
committed
Delete some exception checks
Ben Grant
committed
review suggestion
Ben Grant
committed
slop
Ben Grant
committed
Split up assertions in createNodeURLBinding
Ben Grant
committed
Use one helper function to emit events on the next tick
Ben Grant
committed

Commits on May 8, 2025

Fix environmentData crash
Ben Grant
committed
Add test
Ben Grant
committed
Merge branch 'main' into ben/worker-threads-2
Ben Grant
committed
Revert "Use helper methods for errors"
Ben Grant
committed

Commits on May 9, 2025

Fix RefPtr error and debug logs
Ben Grant
committed
Fix StatWatcher errors
Ben Grant
committed