Implement TLS min/max versions and matching CLI behaviour #19531

alii · 2025-05-07T23:18:04Z

What does this PR do?

Fixes #13710

Implements TLS min/max versions with appropriate CLI arguments
Various other tls-related argument validation fixes
Documentation or TypeScript types (it's okay to leave the rest blank in this case)
Code changes

How did you verify your code works?

Tests pass (not yet..)

robobun · 2025-05-07T23:18:12Z

^{Updated 8:45 PM PT - May 21st, 2025}

❌ @alii, your commit 7749bf7 has 22 failures in Build #17097:

test/js/node/tls/node-tls-context.test.ts - 2 failing on 🪟 2019 x64-baseline
test/js/node/tls/node-tls-context.test.ts - 2 failing on 🪟 2019 x64
test/js/node/tls/node-tls-context.test.ts - 1 failing on 🍎 13 aarch64
test/js/node/tls/node-tls-context.test.ts - 2 failing on 🐧 12 x64-asan
test/js/node/tls/node-tls-context.test.ts - 2 failing on 🍎 14 x64
test/js/node/tls/node-tls-context.test.ts - 1 failing on 🍎 14 aarch64
test/js/node/tls/node-tls-context.test.ts - 1 failing on 🍎 13 x64
test/js/node/tls/node-tls-context.test.ts - 2 failing on 🐧 3.21 aarch64
test/js/node/tls/node-tls-context.test.ts - 2 failing on 🐧 3.21 x64
test/js/node/tls/node-tls-context.test.ts - 2 failing on 🐧 12 aarch64
test/js/node/tls/node-tls-context.test.ts - 2 failing on 🐧 20.04 aarch64
test/js/node/tls/node-tls-context.test.ts - 2 failing on 🐧 24.04 aarch64
test/js/node/tls/node-tls-context.test.ts - 2 failing on 🐧 3.21 x64-baseline
test/js/node/tls/node-tls-context.test.ts - 2 failing on 🐧 12 x64-baseline
test/js/node/tls/node-tls-context.test.ts - 2 failing on 🐧 24.04 x64
test/js/node/tls/node-tls-context.test.ts - 2 failing on 🐧 24.04 x64-baseline
test/js/node/tls/node-tls-context.test.ts - 2 failing on 🐧 20.04 x64
test/js/node/tls/node-tls-context.test.ts - 2 failing on 🐧 12 x64
test/js/node/tls/node-tls-context.test.ts - 2 failing on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-tls-connect-pipe.js - timeout on 🐧 12 x64-asan
test/js/node/test/parallel/test-tls-connect-pipe.js - timeout on 🍎 13 aarch64
test/js/node/test/parallel/test-tls-connect-pipe.js - timeout on 🍎 14 aarch64
test/js/node/test/parallel/test-tls-connect-pipe.js - timeout on 🐧 3.21 aarch64
test/js/node/test/parallel/test-tls-connect-pipe.js - timeout on 🐧 3.21 x64
test/js/node/test/parallel/test-tls-connect-pipe.js - timeout on 🐧 20.04 aarch64
test/js/node/test/parallel/test-tls-connect-pipe.js - timeout on 🐧 12 aarch64
test/js/node/test/parallel/test-tls-connect-pipe.js - timeout on 🐧 3.21 x64-baseline
test/js/node/test/parallel/test-tls-connect-pipe.js - timeout on 🐧 12 x64
test/js/node/test/parallel/test-tls-connect-pipe.js - timeout on 🐧 20.04 x64
test/js/node/test/parallel/test-tls-connect-pipe.js - timeout on 🐧 12 x64-baseline
test/js/node/test/parallel/test-tls-connect-pipe.js - timeout on 🐧 24.04 aarch64
test/js/node/test/parallel/test-tls-connect-pipe.js - timeout on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-tls-connect-pipe.js - timeout on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-tls-connect-pipe.js - timeout on 🐧 24.04 x64
test/js/node/test/parallel/test-tls-peer-certificate-multi-keys.js - code 1 on 🪟 2019 x64-baseline
test/js/node/test/parallel/test-tls-peer-certificate-multi-keys.js - code 1 on 🪟 2019 x64
test/js/node/test/parallel/test-tls-peer-certificate-multi-keys.js - code 1 on 🍎 13 aarch64
test/js/node/test/parallel/test-tls-peer-certificate-multi-keys.js - code 1 on 🍎 14 aarch64
test/js/node/test/parallel/test-tls-peer-certificate-multi-keys.js - code 1 on 🐧 12 x64-asan
test/js/node/test/parallel/test-tls-peer-certificate-multi-keys.js - code 1 on 🐧 3.21 aarch64
test/js/node/test/parallel/test-tls-peer-certificate-multi-keys.js - code 1 on 🐧 3.21 x64
test/js/node/test/parallel/test-tls-peer-certificate-multi-keys.js - code 1 on 🐧 12 aarch64
test/js/node/test/parallel/test-tls-peer-certificate-multi-keys.js - code 1 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-tls-peer-certificate-multi-keys.js - code 1 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-tls-peer-certificate-multi-keys.js - code 1 on 🐧 3.21 x64-baseline
test/js/node/test/parallel/test-tls-peer-certificate-multi-keys.js - code 1 on 🐧 20.04 x64
test/js/node/test/parallel/test-tls-peer-certificate-multi-keys.js - code 1 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-tls-peer-certificate-multi-keys.js - code 1 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-tls-peer-certificate-multi-keys.js - code 1 on 🐧 24.04 x64
test/js/node/test/parallel/test-tls-peer-certificate-multi-keys.js - code 1 on 🐧 12 x64
test/js/node/test/parallel/test-tls-peer-certificate-multi-keys.js - code 1 on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-tls-zero-clear-in.js - timeout on 🪟 2019 x64-baseline
test/js/node/test/parallel/test-tls-zero-clear-in.js - timeout on 🪟 2019 x64
test/js/node/test/parallel/test-tls-zero-clear-in.js - timeout on 🐧 12 x64-asan
test/js/node/test/parallel/test-tls-zero-clear-in.js - timeout on 🐧 3.21 aarch64
test/js/node/test/parallel/test-tls-zero-clear-in.js - timeout on 🐧 3.21 x64
test/js/node/test/parallel/test-tls-zero-clear-in.js - timeout on 🐧 12 aarch64
test/js/node/test/parallel/test-tls-zero-clear-in.js - timeout on 🐧 20.04 aarch64
test/js/node/test/parallel/test-tls-zero-clear-in.js - timeout on 🐧 3.21 x64-baseline
test/js/node/test/parallel/test-tls-zero-clear-in.js - timeout on 🐧 12 x64
test/js/node/test/parallel/test-tls-zero-clear-in.js - timeout on 🐧 20.04 x64
test/js/node/test/parallel/test-tls-zero-clear-in.js - timeout on 🐧 12 x64-baseline
test/js/node/test/parallel/test-tls-zero-clear-in.js - timeout on 🐧 24.04 aarch64
test/js/node/test/parallel/test-tls-zero-clear-in.js - timeout on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-tls-zero-clear-in.js - timeout on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-tls-zero-clear-in.js - timeout on 🐧 24.04 x64
test/js/node/test/parallel/test-tls-add-context.js - timeout on 🍎 13 aarch64
test/js/node/test/parallel/test-tls-add-context.js - timeout on 🍎 14 aarch64
test/js/node/test/parallel/test-tls-add-context.js - timeout on 🪟 2019 x64-baseline
test/js/node/test/parallel/test-tls-add-context.js - timeout on 🪟 2019 x64
test/js/node/test/parallel/test-tls-add-context.js - timeout on 🐧 12 x64-asan
test/js/node/test/parallel/test-tls-add-context.js - timeout on 🐧 3.21 aarch64
test/js/node/test/parallel/test-tls-add-context.js - timeout on 🐧 12 aarch64
test/js/node/test/parallel/test-tls-add-context.js - timeout on 🐧 3.21 x64
test/js/node/test/parallel/test-tls-add-context.js - timeout on 🐧 20.04 aarch64
test/js/node/test/parallel/test-tls-add-context.js - timeout on 🐧 24.04 aarch64
test/js/node/test/parallel/test-tls-add-context.js - timeout on 🐧 3.21 x64-baseline
test/js/node/test/parallel/test-tls-add-context.js - timeout on 🐧 24.04 x64
test/js/node/test/parallel/test-tls-add-context.js - timeout on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-tls-add-context.js - timeout on 🐧 12 x64-baseline
test/js/node/test/parallel/test-tls-add-context.js - timeout on 🐧 20.04 x64
test/js/node/test/parallel/test-tls-add-context.js - timeout on 🐧 12 x64
test/js/node/test/parallel/test-tls-add-context.js - timeout on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-http2-create-client-connect.js - code 1 on 🍎 13 aarch64
test/js/node/test/parallel/test-http2-create-client-connect.js - code 1 on 🍎 14 aarch64
test/js/node/test/parallel/test-http2-create-client-connect.js - code 1 on 🪟 2019 x64-baseline
test/js/node/test/parallel/test-http2-create-client-connect.js - code 1 on 🪟 2019 x64
test/js/node/test/parallel/test-http2-create-client-connect.js - code 1 on 🐧 3.21 aarch64
test/js/node/test/parallel/test-http2-create-client-connect.js - code 1 on 🐧 12 aarch64
test/js/node/test/parallel/test-http2-create-client-connect.js - code 1 on 🐧 3.21 x64
test/js/node/test/parallel/test-http2-create-client-connect.js - code 1 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-http2-create-client-connect.js - code 1 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-http2-create-client-connect.js - code 1 on 🐧 3.21 x64-baseline
test/js/node/test/parallel/test-http2-create-client-connect.js - code 1 on 🐧 12 x64-asan
test/js/node/test/parallel/test-http2-create-client-connect.js - code 1 on 🐧 24.04 x64
test/js/node/test/parallel/test-http2-create-client-connect.js - code 1 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-http2-create-client-connect.js - code 1 on 🐧 20.04 x64
test/js/node/test/parallel/test-http2-create-client-connect.js - code 1 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-http2-create-client-connect.js - code 1 on 🐧 12 x64
test/js/node/test/parallel/test-http2-create-client-connect.js - code 1 on 🐧 20.04 x64-baseline
test/js/bun/spawn/spawn.test.ts - 1 failing on 🪟 2019 x64-baseline
test/js/bun/spawn/spawn.test.ts - 1 failing on 🪟 2019 x64
test/js/node/tls/node-tls-server.test.ts - 2 failing on 🪟 2019 x64-baseline
test/js/node/tls/node-tls-server.test.ts - 2 failing on 🪟 2019 x64
test/js/node/tls/node-tls-server.test.ts - 2 failing on 🍎 13 x64
test/js/node/tls/node-tls-server.test.ts - 2 failing on 🍎 14 x64
test/js/node/tls/node-tls-server.test.ts - 1 failing on 🍎 14 aarch64
test/js/node/tls/node-tls-server.test.ts - 2 failing on 🐧 12 x64-asan
test/js/node/tls/node-tls-server.test.ts - 2 failing on 🐧 3.21 aarch64
test/js/node/tls/node-tls-server.test.ts - 1 failing on 🍎 13 aarch64
test/js/node/tls/node-tls-server.test.ts - 2 failing on 🐧 3.21 x64
test/js/node/tls/node-tls-server.test.ts - 2 failing on 🐧 24.04 aarch64
test/js/node/tls/node-tls-server.test.ts - 2 failing on 🐧 20.04 aarch64
test/js/node/tls/node-tls-server.test.ts - 2 failing on 🐧 12 aarch64
test/js/node/tls/node-tls-server.test.ts - 2 failing on 🐧 3.21 x64-baseline
test/js/node/tls/node-tls-server.test.ts - 2 failing on 🐧 24.04 x64-baseline
test/js/node/tls/node-tls-server.test.ts - 2 failing on 🐧 24.04 x64
test/js/node/tls/node-tls-server.test.ts - 2 failing on 🐧 20.04 x64-baseline
test/js/node/tls/node-tls-server.test.ts - 2 failing on 🐧 12 x64-baseline
test/js/node/tls/node-tls-server.test.ts - 2 failing on 🐧 12 x64
test/js/node/tls/node-tls-server.test.ts - 2 failing on 🐧 20.04 x64
test/js/node/tls/node-tls-cert.test.ts - 1 failing on 🪟 2019 x64-baseline
test/js/node/tls/node-tls-cert.test.ts - 1 failing on 🪟 2019 x64
test/js/node/tls/node-tls-cert.test.ts - 1 failing on 🐧 12 x64-asan
test/js/node/tls/node-tls-cert.test.ts - 1 failing on 🍎 13 aarch64
test/js/node/tls/node-tls-cert.test.ts - 1 failing on 🍎 14 x64
test/js/node/tls/node-tls-cert.test.ts - 1 failing on 🐧 3.21 aarch64
test/js/node/tls/node-tls-cert.test.ts - 1 failing on 🍎 14 aarch64
test/js/node/tls/node-tls-cert.test.ts - 1 failing on 🍎 13 x64
test/js/node/tls/node-tls-cert.test.ts - 1 failing on 🐧 3.21 x64
test/js/node/tls/node-tls-cert.test.ts - 1 failing on 🐧 12 aarch64
test/js/node/tls/node-tls-cert.test.ts - 1 failing on 🐧 24.04 aarch64
test/js/node/tls/node-tls-cert.test.ts - 1 failing on 🐧 20.04 aarch64
test/js/node/tls/node-tls-cert.test.ts - 1 failing on 🐧 3.21 x64-baseline
test/js/node/tls/node-tls-cert.test.ts - 1 failing on 🐧 20.04 x64-baseline
test/js/node/tls/node-tls-cert.test.ts - 1 failing on 🐧 24.04 x64
test/js/node/tls/node-tls-cert.test.ts - 1 failing on 🐧 20.04 x64
test/js/node/tls/node-tls-cert.test.ts - 1 failing on 🐧 12 x64
test/js/node/tls/node-tls-cert.test.ts - 1 failing on 🐧 12 x64-baseline
test/js/node/tls/node-tls-cert.test.ts - 1 failing on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-tls-connect-secure-context.js - code 1 on 🪟 2019 x64-baseline
test/js/node/test/parallel/test-tls-connect-secure-context.js - code 1 on 🪟 2019 x64
test/js/node/test/parallel/test-tls-connect-secure-context.js - code 1 on 🍎 14 aarch64
test/js/node/test/parallel/test-tls-connect-secure-context.js - code 1 on 🐧 12 x64-asan
test/js/node/test/parallel/test-tls-connect-secure-context.js - code 1 on 🐧 3.21 aarch64
test/js/node/test/parallel/test-tls-connect-secure-context.js - code 1 on 🍎 13 aarch64
test/js/node/test/parallel/test-tls-connect-secure-context.js - code 1 on 🐧 3.21 x64
test/js/node/test/parallel/test-tls-connect-secure-context.js - code 1 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-tls-connect-secure-context.js - code 1 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-tls-connect-secure-context.js - code 1 on 🐧 12 aarch64
test/js/node/test/parallel/test-tls-connect-secure-context.js - code 1 on 🐧 3.21 x64-baseline
test/js/node/test/parallel/test-tls-connect-secure-context.js - code 1 on 🐧 24.04 x64
test/js/node/test/parallel/test-tls-connect-secure-context.js - code 1 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-tls-connect-secure-context.js - code 1 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-tls-connect-secure-context.js - code 1 on 🐧 12 x64
test/js/node/test/parallel/test-tls-connect-secure-context.js - code 1 on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-tls-connect-secure-context.js - code 1 on 🐧 20.04 x64
test/js/node/test/parallel/test-tls-client-reject-12.js - code 1 on 🪟 2019 x64-baseline
test/js/node/test/parallel/test-tls-client-reject-12.js - code 1 on 🪟 2019 x64
test/js/node/test/parallel/test-tls-client-reject-12.js - code 1 on 🍎 14 aarch64
test/js/node/test/parallel/test-tls-client-reject-12.js - code 1 on 🐧 3.21 aarch64
test/js/node/test/parallel/test-tls-client-reject-12.js - code 1 on 🐧 12 x64-asan
test/js/node/test/parallel/test-tls-client-reject-12.js - code 1 on 🍎 13 aarch64
test/js/node/test/parallel/test-tls-client-reject-12.js - code 1 on 🐧 3.21 x64
test/js/node/test/parallel/test-tls-client-reject-12.js - code 1 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-tls-client-reject-12.js - code 1 on 🐧 12 aarch64
test/js/node/test/parallel/test-tls-client-reject-12.js - code 1 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-tls-client-reject-12.js - code 1 on 🐧 3.21 x64-baseline
test/js/node/test/parallel/test-tls-client-reject-12.js - code 1 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-tls-client-reject-12.js - code 1 on 🐧 12 x64
test/js/node/test/parallel/test-tls-client-reject-12.js - code 1 on 🐧 20.04 x64
test/js/node/test/parallel/test-tls-client-reject-12.js - code 1 on 🐧 24.04 x64
test/js/node/test/parallel/test-tls-client-reject-12.js - code 1 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-tls-client-reject-12.js - code 1 on 🐧 20.04 x64-baseline

🧪 To try this PR locally:

bunx bun-pr 19531

That installs a local version of the PR into your bun-19531 executable, so you can run:

bun-19531 --bun

…rtMetaEnv

…i-and-test

… into ali/tls-min-max-cli-and-test

…i-and-test

alii added 4 commits May 7, 2025 15:26

add test file

d6d1414

errors

35152da

Specify all tls versions according to Node

87c520d

basic wireup of tls min/max

addc357

alii added 25 commits May 7, 2025 16:39

more zig

37a55d2

more

b6ea92f

add the other minmax test

9059426

more coverage, and slightly related ProcessEnv should not extend Impo…

0332642

…rtMetaEnv

fix test impl

4f1233e

changes

7b0e470

consume values

563b8f5

assign tls versions

14ea951

catch unreachable; increased

aae850e

do set min tls

bd51d5e

default to 1.2 min

2baa668

stuff

f32b6d0

debug

4098051

rm debug

7c57c3c

change how versions get passed

23fd3b8

pass tls versions as openssl values

5b767a9

pass openssl values in nativeland

82a019a

nativeland changes

ef6b9da

debug

4037fe9

Merge branch 'main' of github.com:oven-sh/bun into ali/tls-min-max-cl…

5dbd814

…i-and-test

revert openssl changes for dead path

6cb5e1c

unused constants

4c14c7e

rm

38ff15a

2 more test files

8a22127

2 more test files

b6530ba

alii added 29 commits May 15, 2025 14:33

restart

3d94247

passing

f893b08

failing

ceca54e

debug

f5047e9

peek openssl error queue for real reason(🤦‍♂️)

447216a

Almost all cases passing

234fa60

old/invalid protocol

a1b374b

define secure_protocol_method

6154c5d

debug

670d6b5

secure protocol property plumbing

6ab9b1c

almost there

8786ff8

passing bar these

4a663f3

isolate failure

2d57bb1

try

9317dc2

2 failing

5e267af

remove redundant bloat

bdeaea6

rm

00e8701

some debloat

0acdedd

debloat

447a9a6

Merge branch 'main' into ali/tls-min-max-cli-and-test

29a8a45

check verify error code

bf87b05

Merge branch 'ali/tls-min-max-cli-and-test' of github.com:oven-sh/bun…

a1124d6

… into ali/tls-min-max-cli-and-test

debug

4042785

fix: properly map non min/max vers related error codes

3afa13b

remove logs

372b0c3

define consts earlier

38686f4

Merge branch 'main' of github.com:oven-sh/bun into ali/tls-min-max-cl…

53dd1f9

…i-and-test

Merge branch 'main' of github.com:oven-sh/bun into ali/tls-min-max-cl…

2f635c4

…i-and-test

glob srcs

7749bf7

alii closed this Jul 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement TLS min/max versions and matching CLI behaviour #19531

Implement TLS min/max versions and matching CLI behaviour #19531

Uh oh!

alii commented May 7, 2025 •

edited

Loading

Uh oh!

robobun commented May 7, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Implement TLS min/max versions and matching CLI behaviour #19531

Implement TLS min/max versions and matching CLI behaviour #19531

Uh oh!

Conversation

alii commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

How did you verify your code works?

Uh oh!

robobun commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alii commented May 7, 2025 •

edited

Loading

robobun commented May 7, 2025 •

edited

Loading