fix(linter/exhaustive-dependencies): prevent is_callee_of_call_expr flag from leaking into nested expressions

[camc314]

No description provided.

[camc314]

• fix(linter/exhaustive-dependencies): prevent is_callee_of_call_expr flag from leaking into nested expressions #15832 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #15832 will not alter performance

_{Comparing c/11-18-fix_linter_exhaustive-dependencies_prevent_is_callee_of_call_expr_flag_from_leaking_into_nested_expressions (953e0c3) with main (2191ae9)}

Summary

✅ 4 untouched
⏩ 41 skipped¹

Footnotes

1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[camc314]

Merge activity

• Nov 18, 9:26 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Nov 18, 9:31 AM UTC: camc314 added this pull request to the Graphite merge queue.
• Nov 18, 9:36 AM UTC: Merged by the Graphite merge queue.

[Copilot]

Pull Request Overview

This PR fixes a bug in the exhaustive-dependencies linter where the is_callee_of_call_expr flag was leaking into nested expressions during AST traversal. The fix ensures that when recursively visiting member expression objects, the flag is properly reset to prevent incorrect dependency analysis.

Key Changes

• Reset is_callee_of_call_expr flag to false before visiting nested objects in static member expressions
• Restructured code from match to if let for better readability
• Added comprehensive test cases for property access within expressions followed by method calls

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
crates/oxc_linter/src/rules/react/exhaustive_deps.rs	Fixed flag leak by resetting is_callee_of_call_expr before recursive visits; added test cases for nested property access in expressions
crates/oxc_linter/src/snapshots/react_exhaustive_deps.snap	Updated snapshot to reflect correct detection of multiple dependency levels in property chains

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.