fix(Popover): Apply fill class to popover target when fill prop is passed
#7635
+25
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When the
fillprop is passed toTooltipor otherPopover-based components, the.bp6-fillclass was not being applied to the.bp6-popover-targetwrapper div. This caused layout issues when using these components in flex containers, particularly when placing buttons side-by-side where one or more are wrapped in a tooltip.When wrapping a button with
fill={true}in a Tooltip withfill={true}, the button would not fill its container as expected.Example:
https://codesandbox.io/p/sandbox/r93ft3
Root Cause
The
Popovercomponent's target wrapper was missing theClasses.FILLclass in its className computation, even when thefillprop was passed.Example
Given the following use case / layout pattern:
Before: The popover target wrapper lacks the
.bp6-fillclass.After: The popover target wrapper now includes
.bp6-fill.This results in both buttons displaying as equal width as expected.