Skip to content

Conversation

@rcjng
Copy link
Member

@rcjng rcjng commented Nov 14, 2025

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Add bodyContextMenuRendererDependencies as a prop to <Table /> so that consumers can specify what dependencies will trigger a re-render of the Table's context menu content.

This is useful for cases where a menu item might be disabled until some asynchronous event has occurred and the user should see the UI update in real-time rather than having to close the context menu and re-open it again.

Reviewers should focus on:

table.tsx + tableBody.tsx

I tried to follow the precedent for cellRendererDependencies as closely as possible, but chose to implement the re-render triggering in a simpler way by changing the context menu render function reference.

Video

I've updated the table-dev-app to render the current time in the table context menu (just because it's something that updates asynchronously) to demonstrate that the context menu re-renders:

Screen.Recording.2025-11-14.at.12.59.55.mov

@changelog-app
Copy link

changelog-app bot commented Nov 14, 2025

Generate changelog in packages/table-dev-app/changelog/@unreleased

Type (Select exactly one)

  • Feature (Adding new functionality)
  • Improvement (Improving existing functionality)
  • Fix (Fixing an issue with existing functionality)
  • Break (Creating a new major version by breaking public APIs)
  • Deprecation (Removing functionality in a non-breaking way)
  • Migration (Automatically moving data/functionality to a new system)

Description

Add the current time to the Table context menu to demonstrate re-rendering


Generate changelog in packages/table/changelog/@unreleased

Type (Select exactly one)

  • Feature (Adding new functionality)
  • Improvement (Improving existing functionality)
  • Fix (Fixing an issue with existing functionality)
  • Break (Creating a new major version by breaking public APIs)
  • Deprecation (Removing functionality in a non-breaking way)
  • Migration (Automatically moving data/functionality to a new system)

Description

Allow context menu re-rendering for <Table />


Check the box to generate changelog(s)

  • Generate changelog entry

@changelog-app
Copy link

changelog-app bot commented Nov 14, 2025

Successfully generated changelog entries for:

  • packages/table-dev-app/changelog
  • packages/table/changelog

Need to regenerate?

Simply interact with the changelog bot comment again to regenerate these entries.


📋Changelog Preview

✨ Features

  • Add the current time to the Table context menu to demonstrate re-rendering (#7638)

💡 Improvements

  • Allow context menu re-rendering for <Table /> (#7638)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant