-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[Visuals][Colors] Creating new palette #7647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Generate changelog in
|
SASS variables for CSS variablesBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Adding compiling for palette CSS + SCSSBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
packages/colors/src/palette.ts
Outdated
| GREY_700: "#353b43", | ||
| GREY_800: "#1d232d", | ||
| GREY_900: "#080e17", | ||
| GREY_1000: "#000105", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're essentially starting from scratch here, could we consider a nested config?
export const grey = {
100: "#dfe0e2",
200: "#c2c6cb",
300: "#c0c2c5",
400: "#85898f",
500: "#696e75",
600: "#4e535b",
700: "#353b43",
800: "#1d232d",
900: "#080e17",
1000: "#000105",
} as const;
const palette = {
grey,
...
}
// palette.grey[500] => #696e7518c9ead to
a42a398
Compare
Updating color namingBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
07d7181 to
6030c60
Compare
Prettier formattingBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Updating colors to be more consistentBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Updating colorsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Updating formattingBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Checklist
Changes proposed in this pull request:
Adds new palette
Reviewers should focus on:
Screenshot