Skip to content

Conversation

@mm-wang
Copy link
Contributor

@mm-wang mm-wang commented Nov 18, 2025

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Adds new palette

Reviewers should focus on:

Screenshot

@changelog-app
Copy link

changelog-app bot commented Nov 18, 2025

Generate changelog in packages/colors/changelog/@unreleased

Type (Select exactly one)

  • Feature (Adding new functionality)
  • Improvement (Improving existing functionality)
  • Fix (Fixing an issue with existing functionality)
  • Break (Creating a new major version by breaking public APIs)
  • Deprecation (Removing functionality in a non-breaking way)
  • Migration (Automatically moving data/functionality to a new system)

Description

[Visuals][Colors] Creating new palette

Check the box to generate changelog(s)

  • Generate changelog entry

@svc-palantir-github
Copy link

SASS variables for CSS variables

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@svc-palantir-github
Copy link

Adding compiling for palette CSS + SCSS

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

GREY_700: "#353b43",
GREY_800: "#1d232d",
GREY_900: "#080e17",
GREY_1000: "#000105",
Copy link
Contributor

@ggdouglas ggdouglas Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're essentially starting from scratch here, could we consider a nested config?

export const grey = {
    100: "#dfe0e2",
    200: "#c2c6cb",
    300: "#c0c2c5",
    400: "#85898f",
    500: "#696e75",
    600: "#4e535b",
    700: "#353b43",
    800: "#1d232d",
    900: "#080e17",
    1000: "#000105",
} as const;

const palette = {
    grey,
    ...
}

// palette.grey[500] => #696e75

@mm-wang mm-wang force-pushed the margaretw/colors-palette branch from 18c9ead to a42a398 Compare November 19, 2025 04:45
@svc-palantir-github
Copy link

Updating color naming

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@mm-wang mm-wang force-pushed the margaretw/colors-palette branch from 07d7181 to 6030c60 Compare November 19, 2025 05:06
@svc-palantir-github
Copy link

Prettier formatting

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@svc-palantir-github
Copy link

Updating colors to be more consistent

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@svc-palantir-github
Copy link

Updating colors

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@svc-palantir-github
Copy link

Updating formatting

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants