Type hints #2695
Open
Type hints #2695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElLorans
force-pushed
the
type-hints
branch
3 times, most recently
from
2ebd434 to
40b5113
Compare
ElLorans
commented
Nov 2, 2025
ElLorans
force-pushed
the
type-hints
branch
3 times, most recently
from
fbf1e2a to
085221a
Compare
ElLorans
commented
Nov 8, 2025
| [ | ||
| # First arg inherits from BaseModelView. | ||
| # Cannot type hint and allow users to override without type errors | ||
| t.Any, |
Contributor
Author
There was a problem hiding this comment.
Changing this type hint requires users to then type ignore it.
Contributor
Author
|
I do not find a better way to define T_COLUMN_FORMATTERS, so I would merge the PR as it is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #2440
disallow_subclassing_any,disallow_untyped_decorators,disallow_any_generics.I would need help on the best way to define T_COLUMN_FORMATTERS (see the comment)