Type DataFrame
#1481
Merged
Type DataFrame
#1481
+126
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
type-dataframe
branch
from
2330345 to
40fe0fb
Compare
MarcoGorelli
commented
Nov 13, 2025
1 task
cmp0xff
requested changes
Nov 14, 2025
Contributor
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
- Please fix the default values of
axis - Maybe add
# TODO: resolve with pandas-dev/pandas#63111tofrom_dataframe
cmp0xff
requested changes
Nov 14, 2025
pandas-stubs/core/frame.pyi
Outdated
| def truediv( | ||
| self, | ||
| other: complex | ListLike | DataFrame, | ||
| axis: Axis | None = ..., |
Contributor
There was a problem hiding this comment.
Suggested change
| axis: Axis | None = ..., | |
| axis: Axis | None = "columns", |
Member
Author
Contributor
|
Please set the PR to ready (and request a review) when it is ready. Thanks. |
Member
Author
|
sure, thanks, done sorry for the all the commits and good call on #1481 (comment), it revealed a mismatch between |
cmp0xff
approved these changes
Nov 14, 2025
Contributor
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
Thank you @MarcoGorelli , we now have most DataFrame-related functionalities typed!
Member
Author
|
thanks for bearing with me on this one 😅 ! taking a look at index next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return valuecloses #1446