This repository was archived by the owner on Jun 30, 2025. It is now read-only.
feat(config): added the possibility to configure tesseract ocr #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds configuration support for Tesseract OCR, allowing users to specify custom OCR languages for text extraction. Key changes include:
- Introduction of new configuration types in src/types.ts.
- Updates to extractors and use case functions to pass and validate a configuration object.
- Enhancements to tests with concurrent execution and fixture configuration.
Reviewed Changes
Copilot reviewed 10 out of 29 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/types.ts | Added ExtractorConfig and PartialExtractorConfig types. |
| src/extractors/img.extractor.ts | Updated the extractor to receive a config parameter and use its languages. |
| src/extractors.usecases.ts | Modified extractText to parse and pass configuration. |
| src/extractors.usecases.test.ts | Updated fixture handling; tests now run concurrently with config support. |
| src/extractors.models.ts | Updated extractor definition to require a config parameter. |
| src/config.ts | Added config parsing to validate and apply Tesseract languages with a default. |
| src/config.test.ts | Added tests to verify configuration parsing. |
| package.json | Added dependency on @corentinth/chisels. |
| fixtures/009-png-with-french-text/* | Updated expected output and added fixture configuration. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| const mimeType = mime.getType(fixture); | ||
| for (const fixture of fixturesDir) { | ||
| // use test.concurrent to run the tests in parallel -> need to use the provided expect | ||
| test.concurrent(`fixture ${fixture}`, async ({ expect }) => { |
There was a problem hiding this comment.
[nitpick] Consider using the globally imported 'expect' instead of destructuring it from the test context in the test.concurrent callback, as this pattern may be non-standard for Vitest.
Suggested change
| test.concurrent(`fixture ${fixture}`, async ({ expect }) => { | |
| test.concurrent(`fixture ${fixture}`, async () => { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.