-
Notifications
You must be signed in to change notification settings - Fork 52
Add flag to ignore previous approvals on build:approve command #1963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add flag to ignore previous approvals on build:approve command #1963
Conversation
|
@danieldelacruz01 Thanks for your contribution and I see why you might need that flag. I have added some comments on the PR. |
…pprovals-in-build-approve
|
@ninadbstack thanks for the feedback. I've pushed a commit that should resolve the test and lint issues. Let me know if there's anything else you need. |
c100d7d to
c7bb83b
Compare
|
@danieldelacruz01 added some comments |
|
This PR is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
@ninadbstack @this-is-shivamsingh Could you give this another review please, when you have a minute? |
|
|
This PR is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Add flag

--pass-if-previously-approvedtobuild:approvecommand to optionally prevent exiting with an error when the build already has approval.