Skip to content

Conversation

@danieldelacruz01
Copy link

Add flag --pass-if-previously-approved to build:approve command to optionally prevent exiting with an error when the build already has approval.
Image

@ninadbstack
Copy link
Contributor

@danieldelacruz01 Thanks for your contribution and I see why you might need that flag. I have added some comments on the PR.
You can check the failing specs from the lint and build and fix it if you wish. If you want percy team to have a look at it instead please raise a support ticket with browserstack and we would get it fixed.

@danieldelacruz01
Copy link
Author

danieldelacruz01 commented Aug 25, 2025

@ninadbstack thanks for the feedback. I've pushed a commit that should resolve the test and lint issues. Let me know if there's anything else you need.

@danieldelacruz01 danieldelacruz01 force-pushed the ignore-previous-approvals-in-build-approve branch from c100d7d to c7bb83b Compare August 25, 2025 23:33
@this-is-shivamsingh
Copy link
Contributor

@danieldelacruz01 added some comments

@github-actions
Copy link

This PR is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the 🍞 stale Closed due to inactivity label Sep 16, 2025
@danieldelacruz01
Copy link
Author

@ninadbstack @this-is-shivamsingh Could you give this another review please, when you have a minute?

@github-actions github-actions bot removed the 🍞 stale Closed due to inactivity label Sep 30, 2025
@this-is-shivamsingh
Copy link
Contributor

this-is-shivamsingh commented Oct 9, 2025

  • LGTM on the PR
  • We are waiting on QA bandwidth to test and give GTG for merging it, we are expecting to merge it by this month
  • Thank you @danieldelacruz01 for making this change, will be try to make it go in stable release asap

@github-actions
Copy link

This PR is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the 🍞 stale Closed due to inactivity label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍞 stale Closed due to inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants