[PER-6171] Added await for async dom serilization #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prklm10
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the DOM serialization logic to fully support asynchronous operations and adds comprehensive tests to ensure correct handling of async serialization scenarios. The main change ensures that the
PercyDOM.serializefunction is properly awaited, which allows for more robust and flexible snapshot capturing. The new tests verify correct behavior for async serialization, error handling, option passing, and resource management.Async DOM Serialization Improvements:
captureSerializedDOMfunction inindex.jsto properly await the asynchronousPercyDOM.serializecall, ensuring that DOM snapshots are captured reliably in async contexts.Expanded Test Coverage for Async Serialization:
test/index.test.mjsto verify async DOM serialization, including cases for correct awaiting, handling of options, error handling, responsive snapshot capture, cookie management, passing custom options, and handling complex resources.