Improve the performance of ProtocolConformanceReferenceBuilder through parallelism #983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ileitch
requested changes
Oct 25, 2025
Sources/SourceGraph/Mutators/ProtocolConformanceReferenceBuilder.swift
Outdated
Show resolved
Hide resolved
amorde
force-pushed
the
amorde/protocol-conformance-perf
branch
from
77fffad to
acd87ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ProtocolConformanceReferenceBuildertakes a significant amount of time in a monorepo of ours that has a large amount of types and protocols.This PR updates
ProtocolConformanceReferenceBuilderto parallelize the step that searches the graph for implementations of a protocol and for class hierarchies. This reduces the runtime in mentioned monorepo from ~6 minutes to ~70 seconds.