Skip to content

Conversation

@Skillmon
Copy link
Member

@Skillmon Skillmon commented Oct 8, 2025

Motivation for this change

Currently pgfkeys defines \pgfkeysifassignable, and it is used in the following files in current TeX Live:

  • generic/pgfplots/oldpgfcompatib/pgfplotsoldpgfsupp_pgfkeys.code.tex
  • generic/pgf/modules/pgfmoduledatavisualization.code.tex
  • latex/yquant/yquant-langhelper.tex

The code only uses a documented macro, and the documented fact that .@cmd is defined for a command key, so there's no reason why it shouldn't be documented itself.

Checklist

Please signoff your commits to explicitly state your agreement to the Developer Certificate of Origin. If that is not possible you may check the boxes below instead:

  • Code changes are licensed under GPLv2 + LPPLv1.3c NOT APPLICABLE
  • Documentation changes are licensed under FDLv1.2

@muzimuzhi
Copy link
Member

Seems to need a Changelog entry, in CHANGELOG.md.

- Add Matrix chat to README
- Add rhombic polihedra #1022
- Add Developer Certificate of Origin (DCO) to Pull Request template and enforce
- Add test set for `graphdrawing` (gd)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if @hmenke would like the space trimming on released entries.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, please revert those changes and configure your editor correctly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, my bad, that's a setting I made in my editor. @hmenke shall I revert this?

Copy link
Member

@muzimuzhi muzimuzhi Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the answer is "yes".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment wasn't displayed when I wrote mine. Reverted and checked in another shot at the readme.

@hmenke hmenke merged commit 3ee3784 into pgf-tikz:master Oct 12, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants