WIP: Fix swagger.yaml and validate it in GitHub Actions #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple of the API endpoints were missing the `schema` tag, causing failure in processing by openapi-generator.
Note that this makes [pull request 136](phenoscape#136) obsolete.
rpgoldman
changed the title
Contributor
Author
|
@balhoff I think this could make the CI tests more informative. Please review it and let me know what you think. |
Contributor
Author
|
A quick follow-up: the It looks like there are still one or two missing, so I am tagging this as Draft until I have added them. |
rpgoldman
changed the title
Contributor
Author
|
Debugging openAPI YAML is ... not easy. |
Member
|
Thanks so much for doing this! Looks good so far. Do you want to make it a draft PR? There's a little link in the Reviewers box (I always have to search for it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of the API endpoints were missing the
schematag, causing failure in processing by openapi-generator.Also added a schema with description for JSON prefix maps, making #136 obsolete.
Added OpenAPI/Swagger API validation to CI.