-
Notifications
You must be signed in to change notification settings - Fork 402
ci: use local sources when building with Bake #1997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
It's failing with what already cost me some headaches. I forgot when this was failing and what caused it, but just commented out the checkout logic. I feel like we should not do a checkout for a release version and instead let SPC handle that (it supports downloading a specific version). In case no version is specified, just stay on the current branch (aka don't do anything, also if there's no git folder). What do you think? |
|
Good idea, but we should also fix the "dev" workflow. Maybe we could let SPC check out the current Git commit? |
|
Btw, there are shallow cloning-related errors in the GNU build, which don't make the build fail. |
|
We don't need to! See: #1968 we can set FRANKENPHP_SOURCE_PATH to build with the current directory. If we don't have the version of the code we want to build with available, spc can download it with the download command (tags, not commits). |
Yeah, they were caused by cross-device copying or something, can be ignored. |
|
Can you rebase on top of main please? |
acc574e to
143a6f3
Compare
|
@henderkes the infamous "#30 ERROR: write /go/src/app/dist/static-php-cli/buildroot/bin/frankenphp: no space left on device" is back |
8929bc7 to
335ce26
Compare
309eaaf to
1307b4a
Compare
1307b4a to
b72f093
Compare
|
Oh I think I get it, it doesn't use the build-static-gnu.Dockerfile, does it? The last step is the one responsible for deleting the source and download folders. |
Fixes #1993
Because of a change introduced in the latest version of the Docker Bake Action, Bake downloads the sources from the main Git branch instead of using the local Git tree.