Skip to content

Conversation

@dunglas
Copy link
Member

@dunglas dunglas commented Nov 19, 2025

Fixes #1993

Because of a change introduced in the latest version of the Docker Bake Action, Bake downloads the sources from the main Git branch instead of using the local Git tree.

@henderkes
Copy link
Contributor

It's failing with what already cost me some headaches. I forgot when this was failing and what caused it, but just commented out the checkout logic.

I feel like we should not do a checkout for a release version and instead let SPC handle that (it supports downloading a specific version). In case no version is specified, just stay on the current branch (aka don't do anything, also if there's no git folder).

What do you think?

@dunglas
Copy link
Member Author

dunglas commented Nov 19, 2025

Good idea, but we should also fix the "dev" workflow. Maybe we could let SPC check out the current Git commit?

@dunglas
Copy link
Member Author

dunglas commented Nov 19, 2025

Btw, there are shallow cloning-related errors in the GNU build, which don't make the build fail.

@henderkes
Copy link
Contributor

We don't need to! See: #1968 we can set FRANKENPHP_SOURCE_PATH to build with the current directory. If we don't have the version of the code we want to build with available, spc can download it with the download command (tags, not commits).

@henderkes
Copy link
Contributor

Btw, there are shallow cloning-related errors in the GNU build, which don't make the build fail.

Yeah, they were caused by cross-device copying or something, can be ignored.

@henderkes
Copy link
Contributor

Can you rebase on top of main please?

@dunglas dunglas force-pushed the ci/bake-local-source branch from acc574e to 143a6f3 Compare November 19, 2025 14:37
@dunglas
Copy link
Member Author

dunglas commented Nov 19, 2025

@henderkes the infamous "#30 ERROR: write /go/src/app/dist/static-php-cli/buildroot/bin/frankenphp: no space left on device" is back

@dunglas dunglas force-pushed the ci/bake-local-source branch 3 times, most recently from 8929bc7 to 335ce26 Compare November 19, 2025 15:52
@dunglas
Copy link
Member Author

dunglas commented Nov 19, 2025

@dunglas dunglas force-pushed the ci/bake-local-source branch 2 times, most recently from 309eaaf to 1307b4a Compare November 19, 2025 16:01
@dunglas dunglas force-pushed the ci/bake-local-source branch from 1307b4a to b72f093 Compare November 19, 2025 16:08
@henderkes
Copy link
Contributor

Oh I think I get it, it doesn't use the build-static-gnu.Dockerfile, does it?

The last step is the one responsible for deleting the source and download folders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The static binary available in the releases is compiled from the main branch not from the latest tags

3 participants