Skip to content

Fix undefined exports issue #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

Fix undefined exports issue #375

merged 1 commit into from
Apr 15, 2025

Conversation

@clayallsopp
Copy link
Contributor

@clayallsopp clayallsopp commented Apr 15, 2025 •
edited
Loading

  • This closes Failed to find script #374
  • I added a unit test for this behavior (now that this logic is no longer done via patch-package), but the unit test would also not have caught this behavior because exports / exports.scripts is actually defined in the NodeJS runtime (which is also why this didn't get caught by TypeScript)
  • I am looking into why the Storybooks didn't catch this / surface this
    • Ah right, the storybooks aren't setup to hit this exact case (unmounting while the script is still loading)
  • Will release this as 4.0.1

@clayallsopp clayallsopp merged commit 5103fa7 into master Apr 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kbaig-plaid kbaig-plaid kbaig-plaid approved these changes

@phoenixy1 phoenixy1 Awaiting requested review from phoenixy1

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failed to find script

3 participants

@clayallsopp @kbaig-plaid