Skip to content

Remove Vote.Verify() #3837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
OnedgeLee wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove Vote.Verify() #3837

OnedgeLee wants to merge 1 commit into from

Conversation

@OnedgeLee
Copy link
Contributor

@OnedgeLee OnedgeLee commented Jun 20, 2024

Context

  1. Vote is verified on the constructor
  2. Vote always have non-null ValidatorPublicKey.

@OnedgeLee OnedgeLee force-pushed the chore/clean-consensus branch 3 times, most recently from 9f52180 to f13ade5 Compare June 20, 2024 06:55
@riemannulus riemannulus force-pushed the chore/clean-consensus branch from f13ade5 to 1f00fc0 Compare June 20, 2024 07:05
@OnedgeLee OnedgeLee force-pushed the chore/clean-consensus branch from 1f00fc0 to f367ec7 Compare June 20, 2024 07:16
@OnedgeLee OnedgeLee marked this pull request as draft June 20, 2024 09:15
@OnedgeLee
Copy link
Contributor Author

OnedgeLee commented Jun 20, 2024

Seems to be fail on Libplanet.Net.Tests.Consensus.ContextNonProposerTest.EnterPreVoteNilOneThird

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greymistcube greymistcube Awaiting requested review from greymistcube

@riemannulus riemannulus Awaiting requested review from riemannulus

At least 1 approving review is required to merge this pull request.

Assignees

@OnedgeLee OnedgeLee

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@OnedgeLee