Skip to content

Better staking overview #11930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Better staking overview #11930

wants to merge 7 commits into from

Conversation

@kianenigma
Copy link
Contributor

@kianenigma kianenigma commented Oct 19, 2025

Half backed approach. Still not quite good as:

  1. We are probably loading the entire nominator list under the hood, while we should not, which slows down the page. We only need to read ErasStakersOverview here
  2. This data that comes only has the first page of nominators, which is why if you open this on westend, all validators have nominator count 64 (incorrect.)

@kianenigma kianenigma mentioned this pull request Oct 19, 2025
Merged
10 tasks
@kianenigma kianenigma changed the title Kiz overview Better staking overview Oct 19, 2025
github-merge-queue bot pushed a commit to paritytech/polkadot-sdk that referenced this pull request Oct 20, 2025
@kianenigma @github-actions
[AHM/Staking] Allow own stake to be collected in all pages (#10051)
369cdfb 
TLDR: Thanks to a number of reports from Kusama validator, we have been
investigating an issue where the self stake of some validators is not
present in `ErasStakersPaged` and `ErasStakersOverview`, and
consequently not earning staking rewards.

After investigation, it was clear that the `polkadot-staking-miner` is
doing the right thing, and the self-stake is indeed submitted to the
chain as a part of the staking election result.

The root cause in how `pallet-staking-async` ingests the staking
election result. This code **made a (wrong) assumption that self-stake
is only present in the first page of a multi-page election. This PR
fixes this issue.**

---

- [x] (nice to have) revisit try-state checks of the pallet,
`ErasStakersPaged`, `ErasStakersOverview` and `ErasTotalStake` are
triple checked for correctness
- [ ] (nice to have) fix related displays in PJS:
polkadot-js/apps#11930
- [ ] backport to 2507 and 2509
- Westend 
- [ ] Find a similar issue in westend for monitoring
(paritytech/devops#4402)
  - [ ] Upgrade westend to a branch/release containing this fix 
- [ ] Upgrade westend with this fix, observe test examples are resolved
- [ ] Bump backported version in `fellowship/runtimes`
- [ ] Release 1.9.3 for Kusama with this fix
- [ ] Ensure known test cases are fixed
- One example: `F2WyUUFXLYnBg6acv7t2KFzH6D7CyNcvC4mRCwUdsHTUB4t` (in
election round 46, likely repeating in subsequent ones too)
- This PR will be part of Polkadot release 2.0.0, the Polkadot AHM.
- [ ] Forum post with further explanation once PR is merged.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit to paritytech/polkadot-sdk that referenced this pull request Oct 20, 2025
@kianenigma @github-actions
[AHM/Staking] Allow own stake to be collected in all pages (#10051)
317d6fe 
TLDR: Thanks to a number of reports from Kusama validator, we have been
investigating an issue where the self stake of some validators is not
present in `ErasStakersPaged` and `ErasStakersOverview`, and
consequently not earning staking rewards.

After investigation, it was clear that the `polkadot-staking-miner` is
doing the right thing, and the self-stake is indeed submitted to the
chain as a part of the staking election result.

The root cause in how `pallet-staking-async` ingests the staking
election result. This code **made a (wrong) assumption that self-stake
is only present in the first page of a multi-page election. This PR
fixes this issue.**

---

- [x] (nice to have) revisit try-state checks of the pallet,
`ErasStakersPaged`, `ErasStakersOverview` and `ErasTotalStake` are
triple checked for correctness
- [ ] (nice to have) fix related displays in PJS:
polkadot-js/apps#11930
- [ ] backport to 2507 and 2509
- Westend 
- [ ] Find a similar issue in westend for monitoring
(paritytech/devops#4402)
  - [ ] Upgrade westend to a branch/release containing this fix 
- [ ] Upgrade westend with this fix, observe test examples are resolved
- [ ] Bump backported version in `fellowship/runtimes`
- [ ] Release 1.9.3 for Kusama with this fix
- [ ] Ensure known test cases are fixed
- One example: `F2WyUUFXLYnBg6acv7t2KFzH6D7CyNcvC4mRCwUdsHTUB4t` (in
election round 46, likely repeating in subsequent ones too)
- This PR will be part of Polkadot release 2.0.0, the Polkadot AHM.
- [ ] Forum post with further explanation once PR is merged.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit to paritytech/polkadot-sdk that referenced this pull request Oct 20, 2025
@kianenigma @github-actions
[AHM/Staking] Allow own stake to be collected in all pages (#10051)
5eeff38 
TLDR: Thanks to a number of reports from Kusama validator, we have been
investigating an issue where the self stake of some validators is not
present in `ErasStakersPaged` and `ErasStakersOverview`, and
consequently not earning staking rewards.

After investigation, it was clear that the `polkadot-staking-miner` is
doing the right thing, and the self-stake is indeed submitted to the
chain as a part of the staking election result.

The root cause in how `pallet-staking-async` ingests the staking
election result. This code **made a (wrong) assumption that self-stake
is only present in the first page of a multi-page election. This PR
fixes this issue.**

---

- [x] (nice to have) revisit try-state checks of the pallet,
`ErasStakersPaged`, `ErasStakersOverview` and `ErasTotalStake` are
triple checked for correctness
- [ ] (nice to have) fix related displays in PJS:
polkadot-js/apps#11930
- [ ] backport to 2507 and 2509
- Westend 
- [ ] Find a similar issue in westend for monitoring
(paritytech/devops#4402)
  - [ ] Upgrade westend to a branch/release containing this fix 
- [ ] Upgrade westend with this fix, observe test examples are resolved
- [ ] Bump backported version in `fellowship/runtimes`
- [ ] Release 1.9.3 for Kusama with this fix
- [ ] Ensure known test cases are fixed
- One example: `F2WyUUFXLYnBg6acv7t2KFzH6D7CyNcvC4mRCwUdsHTUB4t` (in
election round 46, likely repeating in subsequent ones too)
- This PR will be part of Polkadot release 2.0.0, the Polkadot AHM.
- [ ] Forum post with further explanation once PR is merged.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit to paritytech/polkadot-sdk that referenced this pull request Oct 20, 2025
@kianenigma @github-actions
[AHM/Staking] Allow own stake to be collected in all pages (#10051)
56e4b10 
TLDR: Thanks to a number of reports from Kusama validator, we have been
investigating an issue where the self stake of some validators is not
present in `ErasStakersPaged` and `ErasStakersOverview`, and
consequently not earning staking rewards.

After investigation, it was clear that the `polkadot-staking-miner` is
doing the right thing, and the self-stake is indeed submitted to the
chain as a part of the staking election result.

The root cause in how `pallet-staking-async` ingests the staking
election result. This code **made a (wrong) assumption that self-stake
is only present in the first page of a multi-page election. This PR
fixes this issue.**

---

- [x] (nice to have) revisit try-state checks of the pallet,
`ErasStakersPaged`, `ErasStakersOverview` and `ErasTotalStake` are
triple checked for correctness
- [ ] (nice to have) fix related displays in PJS:
polkadot-js/apps#11930
- [ ] backport to 2507 and 2509
- Westend 
- [ ] Find a similar issue in westend for monitoring
(paritytech/devops#4402)
  - [ ] Upgrade westend to a branch/release containing this fix 
- [ ] Upgrade westend with this fix, observe test examples are resolved
- [ ] Bump backported version in `fellowship/runtimes`
- [ ] Release 1.9.3 for Kusama with this fix
- [ ] Ensure known test cases are fixed
- One example: `F2WyUUFXLYnBg6acv7t2KFzH6D7CyNcvC4mRCwUdsHTUB4t` (in
election round 46, likely repeating in subsequent ones too)
- This PR will be part of Polkadot release 2.0.0, the Polkadot AHM.
- [ ] Forum post with further explanation once PR is merged.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
paritytech-release-backport-bot bot pushed a commit to paritytech/polkadot-sdk that referenced this pull request Oct 20, 2025
@kianenigma @github-actions
[AHM/Staking] Allow own stake to be collected in all pages (#10051)
3e18df1 
TLDR: Thanks to a number of reports from Kusama validator, we have been
investigating an issue where the self stake of some validators is not
present in `ErasStakersPaged` and `ErasStakersOverview`, and
consequently not earning staking rewards.

After investigation, it was clear that the `polkadot-staking-miner` is
doing the right thing, and the self-stake is indeed submitted to the
chain as a part of the staking election result.

The root cause in how `pallet-staking-async` ingests the staking
election result. This code **made a (wrong) assumption that self-stake
is only present in the first page of a multi-page election. This PR
fixes this issue.**

---

- [x] (nice to have) revisit try-state checks of the pallet,
`ErasStakersPaged`, `ErasStakersOverview` and `ErasTotalStake` are
triple checked for correctness
- [ ] (nice to have) fix related displays in PJS:
polkadot-js/apps#11930
- [ ] backport to 2507 and 2509
- Westend
- [ ] Find a similar issue in westend for monitoring
(paritytech/devops#4402)
  - [ ] Upgrade westend to a branch/release containing this fix
- [ ] Upgrade westend with this fix, observe test examples are resolved
- [ ] Bump backported version in `fellowship/runtimes`
- [ ] Release 1.9.3 for Kusama with this fix
- [ ] Ensure known test cases are fixed
- One example: `F2WyUUFXLYnBg6acv7t2KFzH6D7CyNcvC4mRCwUdsHTUB4t` (in
election round 46, likely repeating in subsequent ones too)
- This PR will be part of Polkadot release 2.0.0, the Polkadot AHM.
- [ ] Forum post with further explanation once PR is merged.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 56e4b10)
paritytech-release-backport-bot bot pushed a commit to paritytech/polkadot-sdk that referenced this pull request Oct 20, 2025
@kianenigma @github-actions
[AHM/Staking] Allow own stake to be collected in all pages (#10051)
8a388a4 
TLDR: Thanks to a number of reports from Kusama validator, we have been
investigating an issue where the self stake of some validators is not
present in `ErasStakersPaged` and `ErasStakersOverview`, and
consequently not earning staking rewards.

After investigation, it was clear that the `polkadot-staking-miner` is
doing the right thing, and the self-stake is indeed submitted to the
chain as a part of the staking election result.

The root cause in how `pallet-staking-async` ingests the staking
election result. This code **made a (wrong) assumption that self-stake
is only present in the first page of a multi-page election. This PR
fixes this issue.**

---

- [x] (nice to have) revisit try-state checks of the pallet,
`ErasStakersPaged`, `ErasStakersOverview` and `ErasTotalStake` are
triple checked for correctness
- [ ] (nice to have) fix related displays in PJS:
polkadot-js/apps#11930
- [ ] backport to 2507 and 2509
- Westend
- [ ] Find a similar issue in westend for monitoring
(paritytech/devops#4402)
  - [ ] Upgrade westend to a branch/release containing this fix
- [ ] Upgrade westend with this fix, observe test examples are resolved
- [ ] Bump backported version in `fellowship/runtimes`
- [ ] Release 1.9.3 for Kusama with this fix
- [ ] Ensure known test cases are fixed
- One example: `F2WyUUFXLYnBg6acv7t2KFzH6D7CyNcvC4mRCwUdsHTUB4t` (in
election round 46, likely repeating in subsequent ones too)
- This PR will be part of Polkadot release 2.0.0, the Polkadot AHM.
- [ ] Forum post with further explanation once PR is merged.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 56e4b10)
@kianenigma kianenigma mentioned this pull request Oct 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kianenigma