Skip to content

Conversation

@pannone
Copy link

@pannone pannone commented Aug 1, 2024

Fixed issue #532

@pannone pannone requested review from OJFord and posquit0 as code owners August 1, 2024 15:47
@github-actions github-actions bot added the size/XS Extra Small size issue or PR. label Aug 1, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Welcome! Looks like this is your first pull request.

Hey, thanks for your contribution! Please give us a bit of time to review it. 😄

Copy link

@galaris galaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implements the mentioned fix correctly

@mitcdh
Copy link

mitcdh commented Aug 3, 2024

Does this preserve the original distances? Everything appears more spaced out now than compiling with -2.0mm on previous versions.

@ericswpark
Copy link
Contributor

This doesn't seem like the correct fix, or there might be another bug that was introduced by the update to the LaTeX distributions (i.e. not a complete fix). The new renders add a lot more whitespace with the 2 mm option.

Copy link
Collaborator

@OJFord OJFord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thanks both; all for sorting it for MacTex 2024 & whatever the full set of newly problematic variants is, but we need to keep it working as-was, both with old/different versions and rendered as similarly as possible in the new.

(Just 'requesting changes' to highlight it and block inadvertent merge.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra Small size issue or PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants