Add DeviceLoadStatus Support to General Diagnostics Cluster #42235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for the DeviceLoadStatus attribute within the General Diagnostics Cluster. The implementation correctly integrates with InteractionModelEngine, ReportScheduler, and SessionManager to gather and expose relevant metrics such as subscription counts and Interaction Model message statistics. The changes are well-structured, and a dedicated unit test has been added to verify the new message counting functionality in SessionManager.
One potential area for improvement is the explicit casting of uint32_t values from GetNumActiveReadHandlers to uint16_t for currentSubscriptions and currentSubscriptionsForFabric in the DeviceLoadStruct. While these fields are defined as uint16 in the Matter specification, a runtime check or assertion could prevent potential data truncation if the number of active read handlers ever exceeds the maximum value of uint16_t.
src/app/clusters/general-diagnostics-server/GeneralDiagnosticsCluster.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/general-diagnostics-server/GeneralDiagnosticsCluster.cpp
Outdated
Show resolved
Hide resolved
|
PR #42235: Size comparison from 3aee644 to 9773474 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
src/app/clusters/general-diagnostics-server/GeneralDiagnosticsCluster.cpp
Outdated
Show resolved
Hide resolved
tcarmelveilleux
approved these changes
Dec 2, 2025
|
PR #42235: Size comparison from 3aee644 to dc2e76d Full report (5 builds for cc32xx, realtek, stm32)
|
|
PR #42235: Size comparison from 3aee644 to 5f77101 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
andy31415
reviewed
Dec 3, 2025
src/app/clusters/general-diagnostics-server/GeneralDiagnosticsCluster.cpp
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Dec 3, 2025
src/app/clusters/general-diagnostics-server/GeneralDiagnosticsCluster.cpp
Outdated
Show resolved
Hide resolved
|
PR #42235: Size comparison from 078ba11 to 22321d6 Full report (5 builds for cc32xx, realtek, stm32)
|
|
PR #42235: Size comparison from 078ba11 to 7c29a55 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
andy31415
reviewed
Dec 5, 2025
andy31415
reviewed
Dec 5, 2025
andy31415
reviewed
Dec 5, 2025
|
PR #42235: Size comparison from 3ced690 to 1218f16 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #42235: Size comparison from 3ced690 to cc8dbec Full report (3 builds for realtek, stm32)
|
|
PR #42235: Size comparison from 3ced690 to 4432d67 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
bzbarsky-apple
approved these changes
Dec 5, 2025
|
PR #42235: Size comparison from 3ced690 to 264d024 Full report (5 builds for cc32xx, realtek, stm32)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the new
DeviceLoadStatusattribute in the general diagnostics cluster. This attribute is protected behind theLOADfeature. A read request for this attribute encodes aDeviceLoadStructthat contains information about the current number of subscriptions, current number of subscriptions for the fabric, total number of subscriptions established, total number of interaction model messages sent, and total number of interaction model messages received. This PR contains changes to theReportSchedulerandSessionManagerto support reporting of these metrics.Related issues
Testing