feat: Add llb symlinks [don't merge until buildkit v0.19.x is released] #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmengelbert
force-pushed
the
pmengelbert/use_llb_symlinks/2
branch
from
d671f25 to
c321f8e
Compare
Contributor
Author
|
This was referenced Jan 9, 2025
Earlier buildkits will not support llb symlinks, so fall back to the old implementation. Signed-off-by: Peter Engelbert <[email protected]>
pmengelbert
force-pushed
the
pmengelbert/use_llb_symlinks/2
branch
from
c321f8e to
8c6d2c2
Compare
Signed-off-by: Peter Engelbert <[email protected]>
Otherwise, we end up with an ExecInfo struct with no Args, which causes buildkit to throw an error. Signed-off-by: Peter Engelbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.