Skip to content

Fix the "Replace activities" placement (Issue #374) #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix the "Replace activities" placement (Issue #374) #380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions extension/extension.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,13 +242,8 @@ export default class Controller extends Extension {
Main.panel._addToPanelBox('dateMenu', dateMenu, -1, Main.panel._rightBox);
} else if (placement == 2) {
// 'Replace activities'
let activitiesMenu = Main.panel._leftBox.get_children()[0].get_children()[0].get_children()[0].get_children()[0];
// If our widget replaces the 'Activities' menu in the panel,
// this property stores the original text so we can restore it
// on ``this.disable``.
this._activitiesText = activitiesMenu.get_text();
activitiesMenu.set_text('');
Main.panel.addToStatusArea("hamster", this.panelWidget, 1, "left");
Main.panel?.statusArea?.activities?.container?.hide?.();
Main.panel.addToStatusArea("hamster", this.panelWidget, 10, "left");
} else if (placement == 3) {
// 'Center'
Main.panel.addToStatusArea("hamster", this.panelWidget, 1, "center");
Expand All @@ -271,8 +266,7 @@ export default class Controller extends Extension {
Main.panel._centerBox.remove_child(this.panelWidget.container);
} else if (placement == 2) {
// We replaced the 'Activities' menu
let activitiesMenu = Main.panel._leftBox.get_children()[0].get_children()[0].get_children()[0].get_children()[0];
activitiesMenu.set_text(this._activitiesText);
Main.panel?.statusArea?.activities?.container?.show?.();
Main.panel._leftBox.remove_child(this.panelWidget.container);
} else {
Main.panel._rightBox.remove_child(this.panelWidget.container);
Expand Down