Skip to content

Conversation

@kakkoyun
Copy link
Member

@kakkoyun kakkoyun commented Oct 24, 2025

  • chore(go/fmt): Fix formatting issues
  • chore(ci): Add yaml and action formatter/linter to CI
  • chore(.github/workflows): Fix action formats and issues

@kakkoyun kakkoyun marked this pull request as draft October 24, 2025 14:24
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would copy the .yamllint config from prometheus/prometheus.

@kakkoyun kakkoyun force-pushed the chore/actionlint branch 2 times, most recently from b082405 to e6d8472 Compare November 14, 2025 15:29
…nation

Add two new Makefile targets to detect and fix carriage return (CRLF)
line endings that can contaminate the codebase from Windows environments:

- check-crlf: Scans all text files (excluding hidden dirs and vendor)
  for CRLF line endings and fails if any are found
- fix-crlf: Automatically converts CRLF to LF using the tr command

Add CRLF check to CI workflow to catch line ending issues early in PRs.
The check runs immediately after checkout, before any other validation.

Also rename go.yml to validate.yml to better reflect the workflow's
purpose, and fix job name casing (supportedVersions -> supported_versions).

Signed-off-by: Kemal Akkoyun <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>
@kakkoyun kakkoyun marked this pull request as ready for review November 14, 2025 15:35
@kakkoyun kakkoyun requested a review from SuperQ November 14, 2025 15:35
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I merged some PR that upgrades some versions, so you need to rebase, sorry 🙃

LGTM, modulo "#magic___^_^___line", what's that?

**Do you mind updating us on the status?** Is there anything we can help with? If you plan to still work on it, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next 2 weeks, this issue will be closed (we can always reopen a PR if you get back to this!).
Hello 👋 Looks like there was no activity on this amazing PR for the last 60 days. **Do you mind updating us on the status?** Is there anything we can help with? If you plan to still work on it, just comment on this PR or push a commit. Thanks! 🤗 #magic___^_^___line If there will be no activity in the next 2 weeks, this issue will be closed (we can always reopen a PR if you get back to this!).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this #magic___^_^___line ? (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants