-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore(ci): Add yaml and action formatter/linter to CI #1899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
SuperQ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would copy the .yamllint config from prometheus/prometheus.
b082405 to
e6d8472
Compare
…nation Add two new Makefile targets to detect and fix carriage return (CRLF) line endings that can contaminate the codebase from Windows environments: - check-crlf: Scans all text files (excluding hidden dirs and vendor) for CRLF line endings and fails if any are found - fix-crlf: Automatically converts CRLF to LF using the tr command Add CRLF check to CI workflow to catch line ending issues early in PRs. The check runs immediately after checkout, before any other validation. Also rename go.yml to validate.yml to better reflect the workflow's purpose, and fix job name casing (supportedVersions -> supported_versions). Signed-off-by: Kemal Akkoyun <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>
e6d8472 to
431ed50
Compare
Signed-off-by: Kemal Akkoyun <[email protected]>
bwplotka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I merged some PR that upgrades some versions, so you need to rebase, sorry 🙃
LGTM, modulo "#magic___^_^___line", what's that?
| **Do you mind updating us on the status?** Is there anything we can help with? If you plan to still work on it, just comment on this PR or push a commit. Thanks! 🤗 | ||
| If there will be no activity in the next 2 weeks, this issue will be closed (we can always reopen a PR if you get back to this!). | ||
| Hello 👋 Looks like there was no activity on this amazing PR for the last 60 days. **Do you mind updating us on the status?** Is there anything we can help with? If you plan to still work on it, just comment on this PR or push a commit. Thanks! 🤗 #magic___^_^___line If there will be no activity in the next 2 weeks, this issue will be closed (we can always reopen a PR if you get back to this!). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this #magic___^_^___line ? (:
Uh oh!
There was an error while loading. Please reload this page.