asn1: Add support for SEQUENCE OF
#13894
Merged
+80
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facutuesca
force-pushed
the
ft/asn1-sequenceof
branch
from
8613280 to
78c4861
Compare
Signed-off-by: Facundo Tuesca <[email protected]>
facutuesca
force-pushed
the
ft/asn1-sequenceof
branch
from
78c4861 to
096f413
Compare
alex
reviewed
Nov 19, 2025
| encoding, | ||
| ), | ||
| Type::SequenceOf(cls) => { | ||
| let values: Vec<AnnotatedTypeObject<'_>> = value |
Member
There was a problem hiding this comment.
Is it practical to not have to allocate a whole vec and instead just iterate?
Contributor
Author
There was a problem hiding this comment.
can that be done with the existing asn1::SequenceOf API?
alex
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
SEQUENCE OFfields to the ASN.1 API. The fields must be annotated as Python lists:Part of #12283