asn1: Add support for SIZE to SEQUENCE OF
#13899
Merged
+217
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Facundo Tuesca <[email protected]>
facutuesca
force-pushed
the
ft/asn1-size
branch
from
5fb6bde to
d8f766e
Compare
alex
reviewed
Nov 20, 2025
Member
alex
left a comment
alex
left a comment
There was a problem hiding this comment.
we should block size annotations with types we don't do anything with them
| min: int | ||
| max: int | None | ||
|
|
||
| def __new__(cls, min: int, max: int | None) -> Size: ... |
Member
There was a problem hiding this comment.
I guess if you want no min you just do min=0?
| let list_len = list.len(); | ||
| let min = size.get().min; | ||
| let max = size.get().max.unwrap_or(usize::MAX); | ||
| if list_len < min || list_len > max { |
Member
There was a problem hiding this comment.
I think this is like, 2% easier to read as if !(min..=max).contains(&list_len) since thats it unavoidable that it's an inclusive range
| if let Some(size) = &annotated_type.annotation.get().size { | ||
| let min = size.get().min; | ||
| let max = size.get().max.unwrap_or(usize::MAX); | ||
| if values.len() < min || values.len() > max { |
Signed-off-by: Facundo Tuesca <[email protected]>
Contributor
Author
done! |
alex
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
SIZEannotations to the ASN.1 API, starting with fields of typeSEQUENCE OF.Part of #12283