Add PO Number field to Sponsorship model (#255) #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add optional po_number CharField to SponsorshipProfile model - Update admin interface to display and export po_number field - Add po_number to SponsorshipProfileForm for user input - Create migration for the new field - Field is optional
✅ Deploy Preview for pyladiescon-portal-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
Thank you. This is in a good shape. Example |
- Add test in test_forms.py to verify po_number is saved correctly - Add test_po_number_field_is_saved in test_models.py to verify field persistence - Add test_po_number_field_can_be_empty to verify optional behavior
Member
|
Sorry I forgot one thing. Could you please add the field to the Create Sponsor Form? We added various fields there, and the PO number is needed as well. |
Member
|
Now that I've merged your other PR which includes the Sponsorship Profile Detail view, could you add the PO number field to that page as well? Thanks. |
…thub.com/ArnavBallinCode/pyladiescon-portal into feature/add-po-number-to-sponsorship-255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#255