-
Notifications
You must be signed in to change notification settings - Fork 149
Implement pack/unpack helpers #1578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jessegrabowski
wants to merge
14
commits into
pymc-devs:main
Choose a base branch
from
jessegrabowski:pack-unpack
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e401129
Implement split_dims/join_dims helpers
jessegrabowski 23d4f8d
Implement pack helper
jessegrabowski 1497963
Add unpack helper
jessegrabowski d6d7cac
Move pack/unpack to `shape_ops.py` and add `JoinDims` and `SplitDims`…
jessegrabowski 25bce5e
Clean up `SplitDims._make_output_shape`
jessegrabowski 934ae9c
Add docstrings
jessegrabowski 1247bf3
Use `join_dims` in `pack`
jessegrabowski 04f09ac
Respond to feedback
jessegrabowski f7644b6
Appease mypy
jessegrabowski e032a21
Check shape dtype and reject negative axis om SplitDims
jessegrabowski a166aca
Validate input ndim in JoinDims `make_node`
jessegrabowski ef43a80
More mypy
jessegrabowski ad99b11
Address feedback
jessegrabowski f33fc10
Rewrite `JoinDims` and `SplitDims` to `Reshape` in canonicalization
jessegrabowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| from pytensor.graph import node_rewriter | ||
| from pytensor.tensor.rewriting.basic import register_canonicalize | ||
| from pytensor.tensor.shape_ops import JoinDims, SplitDims | ||
|
|
||
|
|
||
| @register_canonicalize | ||
| @node_rewriter([SplitDims]) | ||
| def local_split_dims_to_reshape(fgraph, node): | ||
| """ | ||
| Canonicalize SplitDims Ops to Reshape Ops for further graph reasoning (and dispatch to other backends). | ||
| """ | ||
|
|
||
| x, shape = node.inputs | ||
| axis = node.op.axis | ||
|
|
||
| output_shape = [ | ||
| *x.shape[:axis], | ||
| *shape, | ||
| *x.shape[axis + 1 :], | ||
| ] | ||
|
|
||
| return [x.reshape(output_shape)] | ||
|
|
||
|
|
||
| @register_canonicalize | ||
| @node_rewriter([JoinDims]) | ||
| def local_join_dims_to_reshape(fgraph, node): | ||
| """ | ||
| Canonicalize JoinDims Ops to Reshape Ops for further graph reasoning (and dispatch to other backends). | ||
| """ | ||
|
|
||
| (x,) = node.inputs | ||
| start_axis = node.op.start_axis | ||
| n_axes = node.op.n_axes | ||
|
|
||
| output_shape = [ | ||
| *x.shape[:start_axis], | ||
| -1, | ||
| *x.shape[start_axis + n_axes :], | ||
| ] | ||
|
|
||
| return [x.reshape(output_shape)] | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy stack trace in the rewrites