constraints: fix allows, allows_any and allows_all for generic constraints and increase test coverage
#732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Secrus
approved these changes
May 31, 2024
…aints and increase test coverage
radoering
force-pushed
the
fix-generic-constraint-allows
branch
from
ffc93fb to
e2f14b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #722, I noticed some bugs in the existing implementation of
allows,allows_anyandallows_allfor generic constraints combined with a low test coverage.Further, I had some difficulties to tell what's the expected behavior of
allowscompared toallows_anyandallows_all. When looking into version constraints for comparison, we can see thatallowsexpects a version as argument whileallows_anyandallows_allexpect arbitrary version constraints. The equivalent of a version is a generic constraint with an==operator (there is no explicit class as for version constraints). Therefore, I changedallowsto raise an error when passing another argument than a constraint with an==operator to make the interface more clear.