gh-141004: document pyexpat C API
#141259
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
force-pushed
the
docs/capi/expat-141004
branch
from
6164db5 to
dc77ab0
Compare
picnixz
force-pushed
the
docs/capi/expat-141004
branch
from
dc77ab0 to
5b857a4
Compare
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
Thanks for working on these!
picnixz
commented
Nov 8, 2025
This was referenced Nov 9, 2025
Comment on lines
+9
to
+10
| struct PyExpat_CAPI { | ||
| char *magic; /* set to PyExpat_CAPI_MAGIC */ |
Member
There was a problem hiding this comment.
Let's avoid making code formatting changes in this PR.
vstinner
reviewed
Nov 10, 2025
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
The PyExpat capsule is used to access Modules/pyexpat.c functions in Modules/_elementtree.c. I'm not sure that it was intended to be used outside Modules/_elementtree.c.
A code search on PyPI top 15,000 projects (at 2025-09-22) found no matching projects.
In 2020, I moved the Unicode capsule C structure to the internal C API (pycore_ucnhash.h): commit 47e1afd. Then I renamed the PyUnicodeData_CAPSULE_NAME to make it private: commit 84f7382. I expected lot of complains and broken projects, but no one was impacted :-) It went well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Expat C API does not store a global variable as other C APIs and instead prefer consumers to add both the capsule and the C API pointer in the consumer's state. I don't really llike this but it's probably the best
📚 Documentation preview 📚: https://cpython-previews--141259.org.readthedocs.build/