-
-
Notifications
You must be signed in to change notification settings - Fork 51
Fonts #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fonts #95
Conversation
pythops
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make the default true to show the icons ?
|
Sorry if this is stupid. This is my first Rust code ever. Seems overly verbose somehow. |
|
Can you plz rebase, I have pushed some changes to the main 🙏 |
| Span::from(format!("{}↵ ", if config.fonts { " or " } else { "" })) | ||
| .bold(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can not just remove it. Maybe you can add the name of the key instead, like space or enter. but then you will need to take that change into account to make the help banner responsive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not removed entirely. You can still see what is. Only the weird character was removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I built it, ran it, and I can't find anything that looks wrong. That said, it's difficult without knowing what "right" would've looked like :-)
| Span::from(format!("{}↵ ", if config.fonts { " or " } else { "" })) | ||
| .bold(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here

Add config to not display unusual fonts.