Skip to content

Conversation

@cake-duke
Copy link
Contributor

Add config to not display unusual fonts.

Copy link
Owner

@pythops pythops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the default true to show the icons ?

@cake-duke
Copy link
Contributor Author

Sorry if this is stupid. This is my first Rust code ever. Seems overly verbose somehow.

@pythops
Copy link
Owner

pythops commented Nov 13, 2025

Can you plz rebase, I have pushed some changes to the main 🙏

Comment on lines +39 to +40
Span::from(format!("{}↵ ", if config.fonts { "󱁐 or " } else { "" }))
.bold(),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can not just remove it. Maybe you can add the name of the key instead, like space or enter. but then you will need to take that change into account to make the help banner responsive.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not removed entirely. You can still see what is. Only the weird character was removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2025-11-13-210628_503x162_scrot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built it, ran it, and I can't find anything that looks wrong. That said, it's difficult without knowing what "right" would've looked like :-)

Comment on lines +55 to +56
Span::from(format!("{}↵ ", if config.fonts { "󱁐 or " } else { "" }))
.bold(),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants