Code cleanup of XPU profiler for incoming scope profiler #1177
Conversation
moksiuc
changed the title
|
@EikanWang, @gujinghui |
| errors_.push_back(err_msg); | ||
| const ITraceActivity* act) { | ||
| bool rangeEnabled = captureWindowStartTime_ || captureWindowEndTime_; | ||
| if (rangeEnabled) { |
There was a problem hiding this comment.
@moksiuc Could you give detailed comments for this change? Looks like the code is different from CUDA path.
If this change is for range profiler, let's move to next PRs. If not, please give comments in the code.
| } | ||
|
|
||
| // FIXME: Deprecate this method while activity._sycl_queue_id got correct IDs | ||
| // from PTI |
There was a problem hiding this comment.
This comment should be not reasonable, as there should be no queue ID in SYCL runtime.
Let's remove the comments?
There was a problem hiding this comment.
As far as I know PTI is working on this issue and it is better that the comment stays to remember to remove this method completely in the future.
|
|
||
| void XpuptiActivityApi::bufferRequested(uint8_t** buffer, size_t* size) { | ||
| std::lock_guard<std::mutex> guard(mutex_); | ||
| if (allocatedGpuTraceBuffers_.size() >= (size_t)maxGpuBufferCount_) { |
There was a problem hiding this comment.
@moksiuc Why we do not need to care about the buffer size limitation now? PTI will handle it by itself?
There was a problem hiding this comment.
This path of the code was not used in our case. This 'if' only sets 'stopCollection = true;' what was not used anywhere else.
2 participants
Summary:
Code cleanup of XPU profiler plugin to prepare it for incoming PR with implementation of XPU scope profiler.
Changes: