-
Notifications
You must be signed in to change notification settings - Fork 615
Use new DeviceMesh unflatten to rewrite parallel_dims #1660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fegin
wants to merge
38
commits into
main
Choose a base branch
from
chienchin/new_device_mesh
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wconstab
reviewed
Aug 29, 2025
wconstab
reviewed
Aug 29, 2025
tianyu-l
reviewed
Aug 29, 2025
tianyu-l
reviewed
Aug 29, 2025
ezyang
reviewed
Aug 30, 2025
ezyang
reviewed
Aug 30, 2025
12eca61 to
19e4a23
Compare
tianyu-l
reviewed
Oct 17, 2025
19e4a23 to
178bc11
Compare
wconstab
reviewed
Oct 28, 2025
wconstab
reviewed
Oct 28, 2025
wconstab
reviewed
Oct 28, 2025
tianyu-l
reviewed
Oct 29, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should modify FLUX train.py as it's in core now.
@ruisizhang123 let's adapt SimpleFSDP after this PR is merged.
oh it seems being fixed in #1959
wwwjn
reviewed
Oct 30, 2025
20910ef to
a67e87a
Compare
d6eae58 to
70d6c03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR utilizes the latest APIs provided by DeviceMesh to simplify the creation of all different meshes.
The design philosophy is as follow: