Enable ROCm CI support #1786
Merged
Enable ROCm CI support #1786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g ubuntu folder for cuda Dockerfile.
…Fixed error in integration_tests.py. Fixed lint errors.
…_job_v2.yml for integration_test_8gpu.yaml.
…ily available to run the workflow.
tianyu-l
reviewed
Oct 29, 2025
tianyu-l
reviewed
Oct 29, 2025
akashveramd
force-pushed
the
torchtitan_rocm_support_main
branch
from
045b159 to
b10c0bc
Compare
tianyu-l
approved these changes
Oct 30, 2025
Contributor
tianyu-l
left a comment
tianyu-l
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the hard work!
jquesnelle
pushed a commit
to NousResearch/torchtitan
that referenced
this pull request
Nov 10, 2025
This PR is based out of the original PR pytorch#1260. The original PR was created in a different fork, and it was having issues setting up aws inside the workflow. Since the workflow was running from a forked PR. --------- Co-authored-by: Huy Do <[email protected]>
tianyu-l
pushed a commit
that referenced
this pull request
Nov 12, 2025
…nly (#2016) Addressing following issues in this PR- - Running Torchtitan ROCm workflow on cron schedule & only when push to Main branch. CUDA workflow will run as is. - Refactor Torchtitan test run to address older PR comment #1786 (comment)
tianyu-l
added a commit
that referenced
this pull request
Nov 12, 2025
…& push to Main branch only" (#2017) Reverts PR: #2016 Addressing following issues in this PR- - Running Torchtitan ROCm workflow on cron schedule & only when push to Main branch. CUDA workflow will run as is. - Refactor Torchtitan test run to address older PR comment #1786 (comment) Co-authored-by: tianyu-l <[email protected]>
tianyu-l
pushed a commit
that referenced
this pull request
Nov 19, 2025
…h only (#2018) Addressing following issues in this PR- Running Torchtitan ROCm workflow on cron schedule & only when push to Main branch. CUDA workflow will run as is. Refactor Torchtitan test run to address older PR comment #1786 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based out of the original PR #1260.
The original PR was created in a different fork, and it was having issues setting up aws inside the workflow. Since the workflow was running from a forked PR.