[compiler toolkit] Add Trainer subclass for compiler toolkit #2064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
yiming0416
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
4 tasks
BoyuanFeng
reviewed
Nov 19, 2025
yiming0416
force-pushed
the
yiming/subclass_compiler_toolkit_trainer
branch
from
3eb73ae to
291e903
Compare
tianyu-l
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding CudaGraph pass (#2050) would require some custom logic in Trainer's close() method.
So we create a Trainer subclass in compiler toolkit