forked from bufbuild/protobuf-es
-
Notifications
You must be signed in to change notification settings - Fork 0
Add CEL validation support and update package references #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
josep-qdrant
wants to merge
33
commits into
main
Choose a base branch
from
feat/josep/cel-validation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-es and set version to 0.0.1
…ersion - Updated the version in the generated file headers from v2.10.1 to v0.0.1 for multiple protobuf files including duration_pb.ts, empty_pb.ts, field_mask_pb.ts, go_features_pb.ts, java_features_pb.ts, source_context_pb.ts, struct_pb.ts, timestamp_pb.ts, type_pb.ts, wrappers_pb.ts, minimal-validate_pb.ts, eliza_pb.ts, and default_host_pb.ts. - Changed the closing braces from `};` to `}` in several type definitions to maintain consistency in the generated TypeScript code.
…e actions/cache directly
# Conflicts: # deno/conformance/package.json # package-lock.json # packages/protobuf-conformance/package.json
…ation support for generated types.
…ricter TypeScript types through field omission based on CEL expressions.
…h `never` properties for improved type safety.
…ties to enforce mutual exclusivity for CEL validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce CEL validation proto definitions and implement parsing and type generation. Update documentation and tests for the new feature. Rename the main package to @qdrant/protoc-gen-es and ensure all references and dependencies reflect this change. Clean up generated TypeScript files for consistency.
This pull request introduces several important updates to repository ownership, documentation, and CI/CD workflows. The main highlights include transferring the code generator package to the
@qdrantscope, updating all related documentation and references, adding a new GitHub Actions workflow for publishing to npm, and disabling several existing GitHub workflows. Additionally, there is a significant documentation update introducing support forbuf.validatewith CEL expressions.Repository Ownership and Package Scope Updates:
@qdrant/cloud-frontendteam in.github/CODEOWNERS.@bufbuild/protoc-gen-esto@qdrant/protoc-gen-esin bothREADME.mdandMANUAL.md, reflecting the new package scope. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Documentation Improvements:
MANUAL.mddocumenting support forbuf.validateoptions with CEL expressions, including usage examples and explanations of generated TypeScript union types for complex validation rules. [1] [2]CI/CD and GitHub Actions:
.github/workflows/publish.yamlto automate publishing the package to npm and create release notes using Release Drafter.release-drafter.ymlconfiguration file to categorize release notes by features, bug fixes, and maintenance.ifconditions tofalse, includingadd-to-project.yaml,emergency-review-bypass.yaml,notify-approval-bypass.yaml, andpr-title.yaml. [1] [2] [3] [4]Minor Documentation and Formatting Fixes:
MANUAL.mdfor clarity and consistency. [1] [2] [3] [4]These changes collectively modernize the repository's ownership, documentation, and automation, while introducing new validation features for Protobuf code generation.