Listen for page changes to determine when to inject qlty UI elements #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(fixes back/forward navigation)
There was a problem hiding this comment.
Pull Request Overview
Adds a listener for Hotwired Turbo’s turbo:load event to re-inject Qlty UI elements on page navigation, replacing the existing MutationObserver.
- Introduce
addPageLoadListenerhelper insrc/github/events.ts - Replace
MutationObserverintryInjectDiffUIwith Turbo load listener - Use
voidto swallow returned promise and remove the UI-injection guard
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/github/events.ts | New helper to listen for turbo:load and invoke a callback |
| src/github-injector.ts | Swap out the MutationObserver for the Turbo listener, update async calls, remove old dedup guard |
Comments suppressed due to low confidence (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listen for the
turbo:load(see hotwired/turbo) event and re-render qlty UI elements. This removes the expensive MutationObserver & fixes forward/back navigation (see demo)Rendering issue demo
Before:
qlty-forward-back-navigation-before.mp4
After:
qlty-forward-back-navigation-after.mp4