avoid --abort-on-container-exit to allow containers to react to SIGTERM #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
separate-docker-compose-runs
branch
2 times, most recently
from
6143c84 to
6fbf516
Compare
janaiyengar
approved these changes
Sep 26, 2020
Collaborator
janaiyengar
left a comment
janaiyengar
left a comment
There was a problem hiding this comment.
Nice! I have no way to confirm this works, so I'll assume that you know this works :-)
Just one question, but LGTM.
docker-compose.yml
Outdated
Comment on lines
44
to
46
| extra_hosts: | ||
| - "sim:193.167.100.2" | ||
| - "client:193.167.0.100" |
Collaborator
There was a problem hiding this comment.
Is this supposed to be in this PR?
marten-seemann
force-pushed
the
separate-docker-compose-runs
branch
from
6fbf516 to
74c8493
Compare
marten-seemann
force-pushed
the
master
branch
2 times, most recently
from
365141c to
e73ec56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #131. cc @nibanks
Test run: https://github.com/marten-seemann/quic-interop-runner/actions/runs/269891464