RadzenTocItem: take in attributes to pass on to the list item element #2360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akorchev
reviewed
Nov 18, 2025
| /// </summary> | ||
| public partial class RadzenTocItem : ComponentBase, IAsyncDisposable | ||
| { | ||
| /// <summary> |
Collaborator
There was a problem hiding this comment.
Maybe it is easier and less code to just inherit from RadzenBlazorComponent - it has Attributes and does the CSS class merging.
Contributor
Author
There was a problem hiding this comment.
do i make a new PR with the change? i didn't want to just add all the overhead of the base component without approval ^^;
EDIT: nvm, i saw Vladimir changed it. thanks for the quick response!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently our application is having some problems with blazor not liking the anchor of the Table of content items. this has to do with blazor and the url of the application and is not part of radzen, so no worries there :D
however, to prevent blazor's enhanced navigation from screwing up, we need to add an attribute to the TocItem.
dotnet/aspnetcore#52514
dotnet/aspnetcore#8393
dotnet/aspnetcore#51646
etc etc
but we can't add
data-enhance-nav="false"unless the TocItem allows for attributes to be set.this PR implements attributes for the TocItem, but not the full RadzenComponent to not take in as much overhead.
EDIT: i just realised i can fix our issue by setting the attribute on the RadzenToc itself, which implements RadzenComponent & the attributes. Im ok with this being merged or not, but i think it can be useful to have the attributes like class or style